Re: [PATCH 2/3] libata: Remove excess command issue delays

[Jeff Garzik <jeff@garzik.org>]

On 05/15/2010 10:09 AM, Alan Cox wrote:
> On Fri, 14 May 2010 22:24:37 -0400
> Jeff Garzik<jeff@garzik.org>  wrote:
>
>> On 05/05/2010 05:25 AM, Alan Cox wrote:
>>>    /**
>>> + *	ata_sff_exec_command_nopost - issue ATA command to host controller
>>> + *	@ap: port to which command is being issued
>>> + *	@tf: ATA taskfile register set
>>> + *
>>> + *	Issues ATA command, with proper synchronization with interrupt
>>> + *	handler / other threads. This version of the helper does not protect
>>> + *	against any delayed writes done by the underlying fabric, it must
>>> + *	therefore not be used for MMIO devices unless the device handles
>>> + *	the 400nS command delay stall internally.
>>> + *
>>> + *	LOCKING:
>>> + *	spin_lock_irqsave(host lock)
>>> + */
>>> +void ata_sff_exec_command_nopost(struct ata_port *ap,
>>> +                                        const struct ata_taskfile *tf)
>>> +{
>>> +	DPRINTK("ata%u: cmd 0x%X\n", ap->print_id, tf->command);
>>> +	iowrite8(tf->command, ap->ioaddr.command_addr);
>>> +}
>>> +EXPORT_SYMBOL_GPL(ata_sff_exec_command_nopost);
>>
>> where did the 400ns delay go, for the 'nopost' version?
>
> Good question. It should indeed have an ndelay(400) after the iowrite8
> I'll go fix that.

No complaints if I go ahead and add that myself?

I'd like to go ahead and get it in.

	Jeff