From: "Eric Bénard" <eric@eukrea.com>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] commands: add i2c commands
Date: Tue, 18 May 2010 12:04:31 +0200 [thread overview]
Message-ID: <4BF2662F.6080405@eukrea.com> (raw)
In-Reply-To: <1274174808-9516-3-git-send-email-eric@eukrea.com>
Le 18/05/2010 11:26, Eric Bénard a écrit :
> +static int do_i2c_write(struct command *cmdtp, int argc, char *argv[])
.../...
> + for (i = 0; i< count; i++) {
> + tmp = hex2_bin(argv[optind+i]);
> + if (tmp< 1) {
this should be < 0
Eric
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2010-05-18 10:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 9:26 [PATCH 1/3] i2c-imx: change log level for No ACK Eric Bénard
2010-05-18 9:26 ` [PATCH 2/3] i2c: add i2cdev driver Eric Bénard
2010-05-18 9:26 ` [PATCH 3/3] commands: add i2c commands Eric Bénard
2010-05-18 10:04 ` Eric Bénard [this message]
2010-05-19 10:17 ` Sascha Hauer
2010-05-19 11:01 ` [PATCH 2/3] i2c: add i2cdev driver Sascha Hauer
2010-05-19 12:21 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF2662F.6080405@eukrea.com \
--to=eric@eukrea.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.