All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <h.peter.anvin@intel.com>
To: Dave Airlie <airlied@gmail.com>
Cc: Pauli Nieminen <suokkos@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
	Venkatesh Pallipadi <venkatesh.pallipadi@gmail.com>,
	Suresh Siddha <suresh.b.siddha@intel.com>
Subject: Re: [PATCH 5/7] arch/x86: Add array variants for setting memory to wc 	caching.
Date: Tue, 18 May 2010 09:43:42 -0700	[thread overview]
Message-ID: <4BF2C3BE.7060804@intel.com> (raw)
In-Reply-To: <AANLkTilyGz86DlwOvtVolthE66VzkSwj9jDv0s138Egi@mail.gmail.com>

On 05/18/2010 02:34 AM, Dave Airlie wrote:
> On Thu, Apr 1, 2010 at 10:45 PM, Pauli Nieminen <suokkos@gmail.com> wrote:
>> Setting single memory pages at a time to wc takes a lot time in cache flush. To
>> reduce number of cache flush set_pages_array_wc and set_memory_array_wc can be
>> used to set multiple pages to WC with single cache flush.
>>
>> This improves allocation performance for wc cached pages in drm/ttm.
>>
> 
> I've got this in drm-next for quite a while and almost forgot about
> it, I'm meant to be on holidays and I'd really like to just have Linus
> pull my tree,
> 
> I had only one issue with this as we had some problems with doing it
> before but it looks like they've since been fixed in the x86 pat code
> a kernel or two ago so this patch should be fine now.
> 
> its been well tested in drm-next on AGP machines by the author,
> 
> any objections to this?
> 
> Dave.

Acked-by: H. Peter Anvin <hpa@zytor.com>

Go ahead and push it; the patch is straightforward, and the author
(Venki) is reliable.

	-hpa

P.S. Please Cc: all the x86 maintainers, not just Ingo.

  reply	other threads:[~2010-05-18 16:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-01 12:44 [PATCH 1/7] drm/ttm: add pool wc/uc page allocator V3 Pauli Nieminen
2010-04-01 12:44 ` [PATCH 2/7] drm/ttm: Add debugfs output entry to pool allocator Pauli Nieminen
2010-04-01 12:44 ` [PATCH 3/7] drm/radeon/kms: Add ttm page pool debugfs file Pauli Nieminen
2010-04-01 12:45 ` [PATCH 4/7] drm/nouveau: " Pauli Nieminen
2010-04-01 12:45 ` [PATCH 5/7] arch/x86: Add array variants for setting memory to wc caching Pauli Nieminen
2010-05-18  9:34   ` Dave Airlie
2010-05-18 16:43     ` H. Peter Anvin [this message]
2010-05-18 20:54       ` Venkatesh Pallipadi
2010-04-01 12:45 ` [PATCH 6/7] drm/ttm: Use set_pages_array_wc instead of set_memory_wc Pauli Nieminen
2010-04-01 12:45 ` [PATCH 7/7] drm/ttm: Add sysfs interface to control pool allocator Pauli Nieminen
2010-04-01 13:00 ` [PATCH 1/7] drm/ttm: add pool wc/uc page allocator V3 Jerome Glisse
  -- strict thread matches above, loose matches on Subject: below --
2010-03-28 18:16 [PATCH 1/7] drm/ttm: add pool wc/uc page allocator V2 Pauli Nieminen
2010-03-28 18:16 ` [PATCH 5/7] arch/x86: Add array variants for setting memory to wc caching Pauli Nieminen
2010-03-24 22:36 drm/ttm: Pool allocator simplification and sysfs interface Pauli Nieminen
2010-03-24 22:36 ` [PATCH 1/7] drm/ttm: add pool wc/uc page allocator Pauli Nieminen
2010-03-24 22:36   ` [PATCH 2/7] drm/ttm: Add debugfs output entry to pool allocator Pauli Nieminen
2010-03-24 22:36     ` [PATCH 3/7] drm/radeon/kms: Add ttm page pool debugfs file Pauli Nieminen
2010-03-24 22:36       ` [PATCH 4/7] drm/nouveau: " Pauli Nieminen
2010-03-24 22:36         ` [PATCH 5/7] arch/x86: Add array variants for setting memory to wc caching Pauli Nieminen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BF2C3BE.7060804@intel.com \
    --to=h.peter.anvin@intel.com \
    --cc=airlied@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=suokkos@gmail.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=venkatesh.pallipadi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.