From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yang Hongyang <yanghy@cn.fujitsu.com>
Subject: Re: [PATCH] compilation and other small fixes to libxl
Date: Wed, 19 May 2010 09:40:32 +0800
Message-ID: <4BF34190.1040103@cn.fujitsu.com>
References: <AANLkTingavs2x0ugNrh2mlEY_xTYmtUInkOenjTJYMsE@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <AANLkTingavs2x0ugNrh2mlEY_xTYmtUInkOenjTJYMsE@mail.gmail.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Dulloor <dulloor@gmail.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 05/19/2010 09:25 AM, Dulloor wrote:
> Patch fixes the following problems :
> 
> * Some of the library functions such as fscanf, system, and asprintf
> are declared with warn_unused_result (ubuntu server 9.10), causing
> compilation errors in libxl.
> * When using asprintf, the caller is responsible for freeing the memory.
> * memset takes wrong size argument in one of the places (caught by an
> a builtin gcc check).
> 
> -dulloor
> 
> Signed-off-by: Dulloor Rao <dulloor@gmail.com>
> 
> 

Acked-by: Yang Hongyang <yanghy@cn.fujitsu.com> 


-               domuid);
+    {
+        uptime_str = uptime_to_string(uptime, 1);
+       	printf(" %s up %s, %s (%d)\n", current_time_to_string(now),

Here's an indent problem.

+               	uptime_str, libxl_domid_to_name(&ctx, domuid), domuid);
+    }
     else


> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel


-- 
Regards
Yang Hongyang