All of lore.kernel.org
 help / color / mirror / Atom feed
From: viresh.kumar@st.com (Viresh KUMAR)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Watchdog: Adding support for Watchdog found with ARM CortexA9
Date: Wed, 19 May 2010 09:32:57 +0530	[thread overview]
Message-ID: <4BF362F1.5070100@st.com> (raw)
In-Reply-To: <20100518132050.GA8748@mvista.com>

On 5/18/2010 6:50 PM, George G. Davis wrote:
> Hi,
> 
> On Tue, May 18, 2010 at 02:55:21PM +0530, srinidhi kasagar wrote:
>> I do not understand why a new driver is required while having similar one
>> for MPCore watchdog.
>> Please have a look at drivers/watchdog/mpcore_wdt.c
> 
> The same thought occurred to me.  Based on a cursory glance at the Cortex-A9
> MPCore and ARM11 MPCore, the per-CPU watchdogs do appear to be the same
> and could use the same driver.
> 
> Any reason for creating a new driver rather than reusing the ARM11
> MPCore driver?
> 

Sorry Guys!!! Earlier I tried to find existing driver, but couldn't found one.
So sent a new one.

I went through this driver and found some shortcomings in it:
 - It looks it is not used by anyone now, as it required
   asm/hardware/arm_twd.h and it was removed in v2.6.31.
   So it would never compile.
 - It doesn't support clock framework, and works on fixed rate.
 - It works on fixed prescale value (256).
 - It doesn't support WDIOC_GETBOOTSTATUS.

So, please suggest how to proceed as my patch contains all these features.

regards,
viresh kumar.

  reply	other threads:[~2010-05-19  4:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-17  9:54 [PATCH] Watchdog: Adding support for Watchdog found with ARM CortexA9 Viresh KUMAR
2010-05-17  9:56 ` Viresh KUMAR
2010-05-17 10:44 ` Jassi Brar
2010-05-17 11:24   ` Viresh KUMAR
2010-05-18  9:25     ` srinidhi kasagar
2010-05-18 13:20       ` George G. Davis
2010-05-19  4:02         ` Viresh KUMAR [this message]
2010-05-19  5:17           ` srinidhi kasagar
2010-05-19  6:44             ` Viresh KUMAR
2010-09-22 15:36             ` mpcore_wdt A9 questions John Linn
2010-09-22 15:56               ` George G. Davis
2010-05-19  5:32           ` [PATCH] Watchdog: Adding support for Watchdog found with ARM CortexA9 Shilimkar, Santosh
2010-05-19  6:45             ` Viresh KUMAR

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BF362F1.5070100@st.com \
    --to=viresh.kumar@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.