From: Haicheng Li <haicheng.li@linux.intel.com>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: "ak@linux.intel.com" <ak@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
"dnelson@redhat.com" <dnelson@redhat.com>,
Andi Kleen <andi@firstfloor.org>,
"Li, Haicheng" <haicheng.li@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [BUGFIX] [PATCH v2] x86: update all PGDs for direct mapping changes on 64bit.
Date: Wed, 19 May 2010 19:51:04 +0800 [thread overview]
Message-ID: <4BF3D0A8.9050509@linux.intel.com> (raw)
In-Reply-To: <20100420051759.GA15370@localhost>
I'm sorry for my slow response ...
Wu Fengguang wrote:
>> +static void sync_global_pgds(unsigned long start, unsigned long end)
>
> It seems that this function can reuse code with vmalloc_sync_all().
agreed.
> __init_extra_mapping() is not related to memory hotplug (note: the
> __init prefix), so not necessary to change this function?
yes, I think you are right. We don't need to change __init_extra_mapping().
>> vmemmap_populate(struct page *start_page, unsigned long size, int node)
> It's not necessary to introduce the "start" and "err" variables.
> It helps simplify the patch (or you can put them to another cleanup
> only patch).
ok, let's make the fix as simple as possible.
I'll send out the revised version right now. Thank you for the review.
-haicheng
prev parent reply other threads:[~2010-05-19 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 3:28 [BUGFIX] [PATCH v2] x86: update all PGDs for direct mapping changes on 64bit Haicheng Li
2010-04-20 5:17 ` Wu Fengguang
2010-05-19 11:51 ` Haicheng Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF3D0A8.9050509@linux.intel.com \
--to=haicheng.li@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=dnelson@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=haicheng.li@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.