From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benoit Cousson Subject: Re: [PATCH V2] OMAP3: PM: Workaround for DPLL3 Lock issue Date: Wed, 19 May 2010 13:57:51 +0200 Message-ID: <4BF3D23F.6070308@ti.com> References: <1273745535-27139-1-git-send-email-shweta.gulati@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:48327 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751004Ab0ESL54 (ORCPT ); Wed, 19 May 2010 07:57:56 -0400 Received: from dlep35.itg.ti.com ([157.170.170.118]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id o4JBvtEa002076 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 19 May 2010 06:57:55 -0500 In-Reply-To: <1273745535-27139-1-git-send-email-shweta.gulati@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: shweta gulati Cc: "linux-omap@vger.kernel.org" , "Sripathy, Vishwanath" Hi Vishwa, On 5/13/2010 12:12 PM, shweta gulati wrote: > From: Vishwanath Sripathy > > OMAP3430/3630 has a Silicon bug because of which SDRC is > released from IDLE even before Core DPLL has locked. This leads > to undefined behaviour of SDRC DLL. > > This patch has workaround for the same. > > Description of WA for 3430: > Initialization: > Disable DPLL3 automatic mode by default. Issue will not be faced as DPLL3 > is always locked. > > Before CORE Voltage Domain (VDD2) Sleep Transition to RETENTION or OFF mode: > 1. Reduce DPLL3 M2 Frequency to get L3 running at OPP2 Frequency > (by changing M2 Divider value). This is increasing the period duration of > one L3 clock cycle. > o In case of CORE is at OPP3 (166MHz@1.15V): > " Lower the frequency to 83MHz. > > o In case of CORE is at OPP2 (83MHz@1.05V): > " Keep the frequency as it is (83MHz). > > 2. Increase CORE Voltage to 1.2V. This is reducing the timing duration of the > critical path signal which will now fit to one L3 clock cycle. > > 3. Enable DPLL3 Automatic mode. This will ensure proper transition to > RETENTION or OFF mode. > > After CORE Voltage Domain Wakeup Transition from RETENTION or OFF mode: > 1. Disable DPLL3 Automatic mode. > 2. Restore previous DPLL3 M2 Frequency and CORE Voltage values. > > Description of WA for 3630: > Initialization: > Disable DPLL3 automatic mode by default. Issue will not be faced as DPLL3 is always locked. > > Before CORE Voltage Domain(VDD2) Sleep Transition to RETENTION or OFF mode: > 1. Reduce DPLL3 M2 Frequency to get L3 running at OPP50 Frequency > (by changing M2 Divider value) and set VDD2 Voltage for OPP100. > This is increasing the period duration of one L3 clock cycle and reducing > the timing duration of the critical path signal which will now fit to one > L3 clock cycle. > o In case of CORE is at OPP100 (L3=200MHz, VDD2=1.1375V): > " Lower the frequency to 100MHz. > " Keep the voltage as it is (1.1375V). > > o In case of CORE is at OPP50 (L3=100MHz, VDD2=0.93V): > " Keep the frequency as it is (100MHz). > " Increase the voltage to 1.1375V. > > 2. Enable DPLL3 Automatic mode. This will ensure proper transition to > RETENTION or OFF mode. > > After CORE Voltage Domain Wakeup Transition from RETENTION or OFF mode: > 1. Disable DPLL3 Automatic mode. > 2. Restore previous DPLL3 M2 Frequency and CORE Voltage values. > > Also OSWR should not be attempted if DPLL3 has locked. This should be done as part of OSWR patch series. > > Patch tested on 3430SDP and 3630 ZOOM3. > Do you have a more accurate description of the bug? What is the defect ID? The subject is about DPLL3 lock issue, and the description is all about the transition to CORE RET or OFF and playing with voltage... and why OSWR is affected as well? I'm a little bit confused by that... Is this bug dependent of the target power state? What about INACTIVE? Why setting the CORE at 1.2v when the description is only considering 1.1375v? Thanks, Benoit