Re: [Qemu-devel] Re: [PATCH 1/3] cursor: add cursor functions.

[Anthony Liguori <anthony@codemonkey.ws>]

On 05/19/2010 01:57 PM, Blue Swirl wrote:
> On 5/19/10, Gerd Hoffmann<kraxel@redhat.com>  wrote:
>    
>>>        
>>>>          
>>>>> Then there would be no need of parsing.
>>>>>
>>>>>            
>>>>   You would need _two_ bitmaps (e.g. mask and cursor, so that mask=1
>>>>          
>> gives
>>      
>>>> transparent, mask=0 cursor=0 gives black and mask=0 cursor=1 gives
>>>>          
>> white).
>>      
>>>>          
>>> Yes, but it's still packed more efficiently.
>>>
>>>        
>>   Well.  You can't have both.  We can have a efficiently packed format (i.e.
>> two bitmaps).  Or we can do it in a way which doesn't need parsing, but that
>> wouldn't be the most compact format ...
>>      
> You're right, so packing or introducing a small conversion function is
> not critical. I'd still prefer a standard format if possible.
>    

Personally, I'd rather see Gerd's original format but read from a file 
instead of hard coded in a .c file.  IOW, a 
/usr/share/qemu/default-cursor.qpm that contained the appropriate 
strings.  A couple extra lines that made it an xpm I think would be 
worth it too.

Regards,

Anthony Liguori

>>> There's yet another way:
>>> #define _ 0,
>>> #define X 0xff000000,
>>> #define o 0xffffffff,
>>> {
>>>   _ _ _ X o X _ _ _
>>> }
>>> #undef _
>>> #undef X
>>> #undef o
>>>
>>>        
>>   Neat idea ;)
>>
>>   cheers,
>>    Gerd
>>
>>
>>      
>