From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=54962 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OEpAC-0000ZQ-UH for qemu-devel@nongnu.org; Wed, 19 May 2010 15:42:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OEpAB-00044a-Og for qemu-devel@nongnu.org; Wed, 19 May 2010 15:42:44 -0400 Received: from isrv.corpit.ru ([81.13.33.159]:46867) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OEpAB-00044U-Gd for qemu-devel@nongnu.org; Wed, 19 May 2010 15:42:43 -0400 Message-ID: <4BF43F30.4050109@msgid.tls.msk.ru> Date: Wed, 19 May 2010 23:42:40 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <20100519185309.GA27591@lst.de> <4BF43B82.9000806@msgid.tls.msk.ru> <20100519193802.GA29104@lst.de> In-Reply-To: <20100519193802.GA29104@lst.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: Kevin Wolf , qemu-devel@nongnu.org, Avi Kivity 19.05.2010 23:38, Christoph Hellwig wrote: > On Wed, May 19, 2010 at 11:26:58PM +0400, Michael Tokarev wrote: >> Now the question is if the previous patch by Avi is actually >> worth to apply -- I mean this one: >> [Qemu-devel] [PATCH +stable] block: don't attempt to merge overlapping >> requests > > No, that was just a hack, it shouldn't be applied. Actually it's not that obvious. If the actual problem here (besides the mis-comparison) is due to missing barriers or flushes. Avi asked a good question in that thread. But I'm hijacking the thread actually :) /mjt