From: "H. Peter Anvin" <hpa@zytor.com>
To: Avi Kivity <avi@redhat.com>
Cc: Ky Srinivasan <ksrinivasan@novell.com>,
greg@kroah.com, hjanssen@microsoft.com, mingo@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Hyperv detection - code cleanup
Date: Wed, 19 May 2010 13:06:01 -0700 [thread overview]
Message-ID: <4BF444A9.6090709@zytor.com> (raw)
In-Reply-To: <4BF43256.1090004@redhat.com>
On 05/19/2010 11:47 AM, Avi Kivity wrote:
> On 05/19/2010 08:51 PM, H. Peter Anvin wrote:
>> On 05/19/2010 10:12 AM, Ky Srinivasan wrote:
>>
>>> From: K. Y. Srinivasan<ksrinivasan@novell.com>
>>> Subject: Code cleanup - consolidate all hyperv related definitions into one
>>> header file.
>>>
>>>
>> How will this affect KVM? I was under the impression that this was
>> separated out as a constants-only header file for a reason.
>
> It's exported, so any types need to be compatible with userspace (i.e.
> __u32).
>
... and certainly no prototypes for kernel-only functionality.
Right, that's what I thought. So NAK on this patch, too.
-hpa
prev parent reply other threads:[~2010-05-19 20:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 17:12 [PATCH 1/2] Hyperv detection - code cleanup Ky Srinivasan
2010-05-19 17:51 ` H. Peter Anvin
2010-05-19 18:18 ` Ky Srinivasan
2010-05-19 18:47 ` Avi Kivity
2010-05-19 20:06 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF444A9.6090709@zytor.com \
--to=hpa@zytor.com \
--cc=avi@redhat.com \
--cc=greg@kroah.com \
--cc=hjanssen@microsoft.com \
--cc=ksrinivasan@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.