All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Alexander Kurz <linux@blala.de>
Cc: Greg KH <gregkh@suse.de>,
	linux-next@vger.kernel.org, fmhess@users.sourceforge.net,
	Greg KH <greg@kroah.com>, Ian Abbott <abbotti@mev.co.uk>,
	Dominik Brodowski <linux@dominikbrodowski.net>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging/comedi: fixing ni_tio to mite PCI dependancy
Date: Wed, 19 May 2010 14:10:59 -0700	[thread overview]
Message-ID: <4BF453E3.2040301@oracle.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1005200028420.20214@blala.de>

On 05/19/10 13:32, Alexander Kurz wrote:
> On Wed, 19 May 2010, Randy Dunlap wrote:
>> linux-next of 2010-0519:
>> when CONFIG_PCI is not enabled:
>>
>> drivers/staging/comedi/drivers/mite.c: In function 'mite_init':
>> drivers/staging/comedi/drivers/mite.c:89: error: implicit declaration of function 'pci_dev_get'
>> drivers/staging/comedi/drivers/mite.c:89: warning: assignment makes pointer from integer without a cast
>> make[5]: *** [drivers/staging/comedi/drivers/mite.o] Error 1
> 
> thanks, this patch is a follow-up to
>> [PATCH] staging/comedi: fixing 8255 and DAS08 Kconfig dependancies.
> 
> From 9804b6bc8c997433411b24f477417f8e7cc9a19d Mon Sep 17 00:00:00 2001
> From: Alexander Kurz <linux@kbdbabel.org>
> Date: Wed, 19 May 2010 22:23:00 +0200
> Subject: [PATCH 2/2] staging/comedi: fixing ni_tio to mite PCI dependancy
> 
> Signed-off-by: Alexander Kurz <linux@kbdbabel.org>

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>

Thanks.

> ---
>  drivers/staging/comedi/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
> index ebc68ee..0aa2b0d 100644
> --- a/drivers/staging/comedi/Kconfig
> +++ b/drivers/staging/comedi/Kconfig
> @@ -1258,8 +1258,8 @@ config COMEDI_MITE
>  
>  config COMEDI_NI_TIO
>  	tristate "NI general purpose counter support"
> +	depends on COMEDI_MITE
>  	select COMEDI_8255
> -	select COMEDI_MITE
>  	default N
>  	---help---
>  	  Enable support for National Instruments general purpose counters.


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  reply	other threads:[~2010-05-19 21:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-08  8:21 [PATCH] staging/comedi: new Kconfig and Makefiles, drivers grouped by bustype Alexander Kurz
2010-05-10 17:19 ` Randy Dunlap
2010-05-14 19:01 ` Greg KH
2010-05-15  0:29   ` Frank Mori Hess
2010-05-15  3:44     ` Greg KH
2010-05-19 17:32       ` Randy Dunlap
2010-05-19 20:32         ` [PATCH 2/2] staging/comedi: fixing ni_tio to mite PCI dependancy Alexander Kurz
2010-05-19 21:10           ` Randy Dunlap [this message]
2010-05-15 12:03     ` [PATCH] staging/comedi: new Kconfig and Makefiles, drivers grouped by bustype Alexander Kurz
2010-05-16 19:30       ` Frank Mori Hess
2010-05-15 12:09   ` [PATCH] staging/comedi: Kconfig dependancy fixes Alexander Kurz
2010-05-18 21:28     ` Greg KH
2010-05-19 19:13       ` [PATCH] staging/comedi: fixing 8255 and DAS08 Kconfig dependancies Alexander Kurz
2010-05-15 18:48   ` [PATCH] staging/comedi: new Kconfig and Makefiles, drivers grouped by bustype Ian Abbott
2010-05-24 10:05   ` Martyn Welch
2010-05-24 18:41     ` Greg KH
2010-05-25  7:04       ` Martyn Welch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BF453E3.2040301@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=fmhess@users.sourceforge.net \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux@blala.de \
    --cc=linux@dominikbrodowski.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.