From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39182 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OFV4I-0005dr-4p
	for qemu-devel@nongnu.org; Fri, 21 May 2010 12:27:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jan.kiszka@siemens.com>) id 1OFUvq-0002UR-Tt
	for qemu-devel@nongnu.org; Fri, 21 May 2010 12:18:44 -0400
Received: from david.siemens.de ([192.35.17.14]:24013)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jan.kiszka@siemens.com>) id 1OFUvq-0002UC-G6
	for qemu-devel@nongnu.org; Fri, 21 May 2010 12:18:42 -0400
Message-ID: <4BF6B25B.7080508@siemens.com>
Date: Fri, 21 May 2010 18:18:35 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: lsi: Handle removal of selected devices
References: <20100521154926.GA22706@hall.aurel32.net>
	<20100521161736.GA27745@hall.aurel32.net>
In-Reply-To: <20100521161736.GA27745@hall.aurel32.net>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Aurelien Jarno wrote:
> On Fri, May 21, 2010 at 05:49:26PM +0200, Aurelien Jarno wrote:
>> This patch:
>>
>> 64d564094cac5f72eeaeb950c442b773a00d3586 is the first bad commit
>> commit 64d564094cac5f72eeaeb950c442b773a00d3586
>> Author: Jan Kiszka <jan.kiszka@siemens.com>
>> Date:   Tue May 4 14:21:03 2010 +0200
>>
>>     lsi: Handle removal of selected devices
>>
>>     We must not store references to selected devices as they may be
>>     hot-removed. Instead, look up the device based on its tag right before
>>     using it. If the device disappeared, throw an interrupt and disconnect.
>>
>>     Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>     Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>>
>> breaks the versatile machine. qemu-system-arm segfaults during the boot.
> 
> Actually it only seems to be the case with old kernels. I have put the
> material to reproduce the bug here:
> 
> http://temp.aurel32.net/qemu-versatile/
> 

Ah, perfect. Will have a look.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux