From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38719 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OFV45-0005Nl-Oo for qemu-devel@nongnu.org; Fri, 21 May 2010 12:27:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OFV0D-00035P-9M for qemu-devel@nongnu.org; Fri, 21 May 2010 12:23:15 -0400 Received: from hall.aurel32.net ([88.191.82.174]:45227) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OFV0D-00035H-1z for qemu-devel@nongnu.org; Fri, 21 May 2010 12:23:13 -0400 Message-ID: <4BF6B36A.8070702@aurel32.net> Date: Fri, 21 May 2010 18:23:06 +0200 From: Aurelien Jarno MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: lsi: Handle removal of selected devices References: <20100521154926.GA22706@hall.aurel32.net> <20100521161736.GA27745@hall.aurel32.net> <4BF6B25B.7080508@siemens.com> In-Reply-To: <4BF6B25B.7080508@siemens.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: "qemu-devel@nongnu.org" Jan Kiszka a écrit : > Aurelien Jarno wrote: >> On Fri, May 21, 2010 at 05:49:26PM +0200, Aurelien Jarno wrote: >>> This patch: >>> >>> 64d564094cac5f72eeaeb950c442b773a00d3586 is the first bad commit >>> commit 64d564094cac5f72eeaeb950c442b773a00d3586 >>> Author: Jan Kiszka >>> Date: Tue May 4 14:21:03 2010 +0200 >>> >>> lsi: Handle removal of selected devices >>> >>> We must not store references to selected devices as they may be >>> hot-removed. Instead, look up the device based on its tag right before >>> using it. If the device disappeared, throw an interrupt and disconnect. >>> >>> Signed-off-by: Jan Kiszka >>> Signed-off-by: Anthony Liguori >>> >>> breaks the versatile machine. qemu-system-arm segfaults during the boot. >> Actually it only seems to be the case with old kernels. I have put the >> material to reproduce the bug here: >> >> http://temp.aurel32.net/qemu-versatile/ >> > > Ah, perfect. Will have a look. > Thanks. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net