From: Jonathan Cameron <jic23@cam.ac.uk>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH] staging:iio: pull in slab.h for kmalloc funcs
Date: Sun, 23 May 2010 11:12:15 +0100 [thread overview]
Message-ID: <4BF8FF7F.1030008@cam.ac.uk> (raw)
In-Reply-To: <1274598635-12193-1-git-send-email-vapier@gentoo.org>
On 05/23/10 08:10, Mike Frysinger wrote:
> These drivers use kzalloc() but don't include slab.h. They currently
> build though because the spi.h header will pull in slab.h for us. But
> rather than rely on that behavior forever, include slab.h explicitly.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Good point. I should have picked up on that one when doing review / merge
of these. Will keep an eye open for it in future.
Thanks,
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
> ---
> drivers/staging/iio/accel/adis16209_core.c | 2 +-
> drivers/staging/iio/accel/adis16209_ring.c | 1 +
> drivers/staging/iio/accel/adis16220_core.c | 2 +-
> drivers/staging/iio/accel/adis16240_core.c | 2 +-
> drivers/staging/iio/accel/adis16240_ring.c | 1 +
> drivers/staging/iio/gyro/adis16260_core.c | 2 +-
> drivers/staging/iio/gyro/adis16260_ring.c | 1 +
> drivers/staging/iio/imu/adis16300_core.c | 2 +-
> drivers/staging/iio/imu/adis16300_ring.c | 1 +
> drivers/staging/iio/imu/adis16350_core.c | 2 +-
> drivers/staging/iio/imu/adis16350_ring.c | 1 +
> drivers/staging/iio/imu/adis16400_core.c | 2 +-
> drivers/staging/iio/imu/adis16400_ring.c | 1 +
> 13 files changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/adis16209_core.c b/drivers/staging/iio/accel/adis16209_core.c
> index ac375c5..b3acdc3 100644
> --- a/drivers/staging/iio/accel/adis16209_core.c
> +++ b/drivers/staging/iio/accel/adis16209_core.c
> @@ -14,7 +14,7 @@
> #include <linux/device.h>
> #include <linux/kernel.h>
> #include <linux/spi/spi.h>
> -
> +#include <linux/slab.h>
> #include <linux/sysfs.h>
> #include <linux/list.h>
>
> diff --git a/drivers/staging/iio/accel/adis16209_ring.c b/drivers/staging/iio/accel/adis16209_ring.c
> index 533e285..8959ad8 100644
> --- a/drivers/staging/iio/accel/adis16209_ring.c
> +++ b/drivers/staging/iio/accel/adis16209_ring.c
> @@ -6,6 +6,7 @@
> #include <linux/device.h>
> #include <linux/kernel.h>
> #include <linux/spi/spi.h>
> +#include <linux/slab.h>
> #include <linux/sysfs.h>
> #include <linux/list.h>
>
> diff --git a/drivers/staging/iio/accel/adis16220_core.c b/drivers/staging/iio/accel/adis16220_core.c
> index 6de439f..fefeca2 100644
> --- a/drivers/staging/iio/accel/adis16220_core.c
> +++ b/drivers/staging/iio/accel/adis16220_core.c
> @@ -14,7 +14,7 @@
> #include <linux/device.h>
> #include <linux/kernel.h>
> #include <linux/spi/spi.h>
> -
> +#include <linux/slab.h>
> #include <linux/sysfs.h>
> #include <linux/list.h>
>
> diff --git a/drivers/staging/iio/accel/adis16240_core.c b/drivers/staging/iio/accel/adis16240_core.c
> index 54fd6d7..316022f 100644
> --- a/drivers/staging/iio/accel/adis16240_core.c
> +++ b/drivers/staging/iio/accel/adis16240_core.c
> @@ -14,7 +14,7 @@
> #include <linux/device.h>
> #include <linux/kernel.h>
> #include <linux/spi/spi.h>
> -
> +#include <linux/slab.h>
> #include <linux/sysfs.h>
> #include <linux/list.h>
>
> diff --git a/drivers/staging/iio/accel/adis16240_ring.c b/drivers/staging/iio/accel/adis16240_ring.c
> index 26b677b..490d80e 100644
> --- a/drivers/staging/iio/accel/adis16240_ring.c
> +++ b/drivers/staging/iio/accel/adis16240_ring.c
> @@ -6,6 +6,7 @@
> #include <linux/device.h>
> #include <linux/kernel.h>
> #include <linux/spi/spi.h>
> +#include <linux/slab.h>
> #include <linux/sysfs.h>
> #include <linux/list.h>
>
> diff --git a/drivers/staging/iio/gyro/adis16260_core.c b/drivers/staging/iio/gyro/adis16260_core.c
> index c93f4d5..f0246a4 100644
> --- a/drivers/staging/iio/gyro/adis16260_core.c
> +++ b/drivers/staging/iio/gyro/adis16260_core.c
> @@ -14,7 +14,7 @@
> #include <linux/device.h>
> #include <linux/kernel.h>
> #include <linux/spi/spi.h>
> -
> +#include <linux/slab.h>
> #include <linux/sysfs.h>
> #include <linux/list.h>
>
> diff --git a/drivers/staging/iio/gyro/adis16260_ring.c b/drivers/staging/iio/gyro/adis16260_ring.c
> index 4c4390c..2fe7f02 100644
> --- a/drivers/staging/iio/gyro/adis16260_ring.c
> +++ b/drivers/staging/iio/gyro/adis16260_ring.c
> @@ -6,6 +6,7 @@
> #include <linux/device.h>
> #include <linux/kernel.h>
> #include <linux/spi/spi.h>
> +#include <linux/slab.h>
> #include <linux/sysfs.h>
> #include <linux/list.h>
>
> diff --git a/drivers/staging/iio/imu/adis16300_core.c b/drivers/staging/iio/imu/adis16300_core.c
> index 5a7e5ef..bf02fbe 100644
> --- a/drivers/staging/iio/imu/adis16300_core.c
> +++ b/drivers/staging/iio/imu/adis16300_core.c
> @@ -14,7 +14,7 @@
> #include <linux/device.h>
> #include <linux/kernel.h>
> #include <linux/spi/spi.h>
> -
> +#include <linux/slab.h>
> #include <linux/sysfs.h>
> #include <linux/list.h>
>
> diff --git a/drivers/staging/iio/imu/adis16300_ring.c b/drivers/staging/iio/imu/adis16300_ring.c
> index 76cf8a6..9c01994 100644
> --- a/drivers/staging/iio/imu/adis16300_ring.c
> +++ b/drivers/staging/iio/imu/adis16300_ring.c
> @@ -6,6 +6,7 @@
> #include <linux/device.h>
> #include <linux/kernel.h>
> #include <linux/spi/spi.h>
> +#include <linux/slab.h>
> #include <linux/sysfs.h>
> #include <linux/list.h>
>
> diff --git a/drivers/staging/iio/imu/adis16350_core.c b/drivers/staging/iio/imu/adis16350_core.c
> index 0edde73..145966b 100644
> --- a/drivers/staging/iio/imu/adis16350_core.c
> +++ b/drivers/staging/iio/imu/adis16350_core.c
> @@ -14,7 +14,7 @@
> #include <linux/device.h>
> #include <linux/kernel.h>
> #include <linux/spi/spi.h>
> -
> +#include <linux/slab.h>
> #include <linux/sysfs.h>
> #include <linux/list.h>
>
> diff --git a/drivers/staging/iio/imu/adis16350_ring.c b/drivers/staging/iio/imu/adis16350_ring.c
> index 5e9716e..2a0a465 100644
> --- a/drivers/staging/iio/imu/adis16350_ring.c
> +++ b/drivers/staging/iio/imu/adis16350_ring.c
> @@ -6,6 +6,7 @@
> #include <linux/device.h>
> #include <linux/kernel.h>
> #include <linux/spi/spi.h>
> +#include <linux/slab.h>
> #include <linux/sysfs.h>
> #include <linux/list.h>
>
> diff --git a/drivers/staging/iio/imu/adis16400_core.c b/drivers/staging/iio/imu/adis16400_core.c
> index e69e2ce..8957985 100644
> --- a/drivers/staging/iio/imu/adis16400_core.c
> +++ b/drivers/staging/iio/imu/adis16400_core.c
> @@ -21,7 +21,7 @@
> #include <linux/device.h>
> #include <linux/kernel.h>
> #include <linux/spi/spi.h>
> -
> +#include <linux/slab.h>
> #include <linux/sysfs.h>
> #include <linux/list.h>
>
> diff --git a/drivers/staging/iio/imu/adis16400_ring.c b/drivers/staging/iio/imu/adis16400_ring.c
> index 5529b32..66a91ad 100644
> --- a/drivers/staging/iio/imu/adis16400_ring.c
> +++ b/drivers/staging/iio/imu/adis16400_ring.c
> @@ -6,6 +6,7 @@
> #include <linux/device.h>
> #include <linux/kernel.h>
> #include <linux/spi/spi.h>
> +#include <linux/slab.h>
> #include <linux/sysfs.h>
> #include <linux/list.h>
>
prev parent reply other threads:[~2010-05-23 10:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-23 7:10 [PATCH] staging:iio: pull in slab.h for kmalloc funcs Mike Frysinger
2010-05-23 10:12 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF8FF7F.1030008@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-iio@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.