From: Jonathan Cameron <jic23@cam.ac.uk>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 2/2] hwmon: (adm1031) allow setting update
Date: Sun, 23 May 2010 10:28:29 +0000 [thread overview]
Message-ID: <4BF9034D.2050302@cam.ac.uk> (raw)
In-Reply-To: <1270671720-1575-3-git-send-email-iws@ovro.caltech.edu>
...
> @@ -75,6 +79,7 @@ struct adm1031_data {
> int chip_type;
> char valid; /* !=0 if following fields are valid */
> unsigned long last_updated; /* In jiffies */
> + unsigned int update_rate; /* In milliseconds */
Hi,
Just a quick comment. Aren't the unit of a rate typically things per time period?
(i.e. same as frequency) If you want to go with milli seconds, then surely
it should be called update_period.
Jonathan
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2010-05-23 10:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 20:22 [lm-sensors] [PATCH 2/2] hwmon: (adm1031) allow setting update rate Ira W. Snyder
2010-04-13 22:54 ` Ira W. Snyder
2010-04-14 8:46 ` [lm-sensors] [PATCH 2/2] hwmon: (adm1031) allow setting update Jean Delvare
2010-04-14 15:36 ` Ira W. Snyder
2010-04-14 15:46 ` Jean Delvare
2010-05-23 10:28 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF9034D.2050302@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.