All of lore.kernel.org
 help / color / mirror / Atom feed
From: liubo <liubo2009@cn.fujitsu.com>
To: Mike Fedyk <mfedyk@mikefedyk.com>
Cc: miaox@cn.fujitsu.com, Chris Mason <chris.mason@oracle.com>,
	Linux Btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 04/10] btrfs: Add error check for add_to_page_cache_lru
Date: Mon, 24 May 2010 10:34:19 +0800	[thread overview]
Message-ID: <4BF9E5AB.8050506@cn.fujitsu.com> (raw)
In-Reply-To: <AANLkTiktY-iDvlEZZGFjarYFUB97SD6DDAkudo02hthL@mail.gmail.com>

On 05/20/2010 04:43 PM, Mike Fedyk wrote:
> Shouldn't this use a pre-processor label instead of hard coding
> compression sensitivity or readahead tuning?  this way it'll be set in
> one place.
>
>   

All right.

Since Adding a macro may make the whole code harder to read, I add a
"goto" to avoid this kind of hard coding style instead.

Thanks.

-- 
Liubo 



      reply	other threads:[~2010-05-24  2:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-20  7:18 [PATCH 04/10] btrfs: Add error check for add_to_page_cache_lru Miao Xie
2010-05-20  8:43 ` Mike Fedyk
2010-05-24  2:34   ` liubo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BF9E5AB.8050506@cn.fujitsu.com \
    --to=liubo2009@cn.fujitsu.com \
    --cc=chris.mason@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=mfedyk@mikefedyk.com \
    --cc=miaox@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.