From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Subject: Re: serious performance issues with images, audio files, and other "non-code" data Date: Mon, 24 May 2010 02:44:36 -0400 Message-ID: <4BFA2054.6060002@puckerupgames.com> References: <4BEAF941.6040609@puckerupgames.com> <20100514051049.GF6075@coredump.intra.peff.net> <4BED47EA.9090905@puckerupgames.com> <20100517231642.GB12092@coredump.intra.peff.net> <4BF2E168.2020706@puckerupgames.com> <20100518191933.GB2383@coredump.intra.peff.net> <20100518194105.GA4723@coredump.intra.peff.net> <4BF9C678.6010108@puckerupgames.com> <20100524053955.GA4528@coredump.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Nicolas Pitre , git@vger.kernel.org To: Jeff King X-From: git-owner@vger.kernel.org Mon May 24 08:45:00 2010 connect(): No such file or directory Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OGRPI-0000Vi-9S for gcvg-git-2@lo.gmane.org; Mon, 24 May 2010 08:45:00 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756152Ab0EXGok (ORCPT ); Mon, 24 May 2010 02:44:40 -0400 Received: from caiajhbdccac.dreamhost.com ([208.97.132.202]:35462 "EHLO postalmail-a6.g.dreamhost.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756146Ab0EXGoi (ORCPT ); Mon, 24 May 2010 02:44:38 -0400 Received: from dev.newmarket (c-71-225-50-119.hsd1.pa.comcast.net [71.225.50.119]) by postalmail-a6.g.dreamhost.com (Postfix) with ESMTP id 61E01887A6; Sun, 23 May 2010 23:44:37 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5) Gecko/20091204 Thunderbird/3.0 In-Reply-To: <20100524053955.GA4528@coredump.intra.peff.net> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: I agree, no defaults are better than arbitrary defaults. So why is the default "text"? On 05/24/2010 01:39 AM, Jeff King wrote: > On Sun, May 23, 2010 at 08:21:12PM -0400, John wrote: > >> *.jpg binary -delta >> *.png binary -delta >> *.psd binary -delta >> *.gz binary -delta >> *.bz2 binary -delta >> .. and so on. >> >> [...] >> >> Is there any reason why someone would NOT want the above >> ".gitattributes" defined by default? > > I delta jpgs in one of my repositories. It is useful if the exif > metadata changes but the image data does not. I assume you could do the > same with other formats which have compressed and uncompressed portions > (I also do it with video containers). I don't think it would ever make > sense to try to delta gzip'd or bzip'd contents. > > I also don't use "binary", as I use a custom diff driver instead (binary > implies "-diff"). > > As for what should be the default, until now the default has always > been that no gitattributes are defined by default. This is nice because > it's simple to understand; git doesn't care about filenames unless you > tell it to. The downside obviously is that it may not perform optimally > for some unusual workloads without extra configuration. > > We could probably do defaults for some common extensions, but I'm not > really sure where such a thing should end up. For example, I consider > *.psd a uselessly obscure extension, as Adobe doesn't write software for > my platform of choice. Not that I mind having it in git, but rather that > we are inevitably going to miss somebody's pet extension, and then we > are right back where we started with them needing to configure, except > now they also have to figure out which extensions have default > attributes. > > -Peff