From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756192Ab0EXHRx (ORCPT ); Mon, 24 May 2010 03:17:53 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:64111 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753834Ab0EXHRw (ORCPT ); Mon, 24 May 2010 03:17:52 -0400 Message-ID: <4BFA2760.5000508@cn.fujitsu.com> Date: Mon, 24 May 2010 15:14:40 +0800 From: Xiao Guangrong User-Agent: Thunderbird 2.0.0.24 (Windows/20100228) MIME-Version: 1.0 To: Avi Kivity CC: Marcelo Tosatti , LKML , KVM list Subject: Re: [PATCH 1/2] KVM: MMU: allow more page become unsync at gfn mapping time References: <4BF91C34.6020904@cn.fujitsu.com> <4BF932DD.5070900@redhat.com> <4BF9DE88.4060609@cn.fujitsu.com> <4BFA1B94.9010403@redhat.com> In-Reply-To: <4BFA1B94.9010403@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Avi Kivity wrote: > On 05/24/2010 05:03 AM, Xiao Guangrong wrote: >> >> Avi Kivity wrote: >> >> >>>> + if (need_unsync) >>>> + kvm_unsync_pages(vcpu, gfn); >>>> return 0; >>>> } >>>> >>>> >>>> >>> Looks good, I'm just uncertain about role.invalid handling. What's the >>> reasoning here? >>> >>> >> Avi, >> >> Thanks for your reply. >> >> We no need worry about 'role.invalid' here, since we only allow the >> PTE shadow >> pages(role.level == 1) become unsync, and in current code, >> 'role.invalid' is only >> used for root shadow pages. >> > > Right, the invlpg change is not it yet. But I think it should be in > this patch; I don't like subtle dependencies, and it will make the > invplg patch simpler. > OK, i'll fix those two patches, thanks