All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] Tools: set multiple variable with	fw_setenv utility
Date: Mon, 24 May 2010 10:18:25 +0200	[thread overview]
Message-ID: <4BFA3651.2060507@denx.de> (raw)
In-Reply-To: <1274669239.5863.13.camel@ptyser-laptop>

Peter Tyser wrote:
> Hi Stefano,
> 

Hi Peter,

> It'd be nice to document the new functionality you're adding.  Any
> interest in adding a runtime usage message?  It seems like that'd be
> pretty useful.  At a minimum it would be nice to update the description
> in fw_env_main.c to reflect the changes you're making and/or update the
> README.

Agree. I think I will add a -h (help) option in fw_env_main.c, as you
suggest, describing in details how to call the utility.

> Is there a reason to keep fw_env_open around?  It looks like just a call
> to env_init() after the changes above?

The reason is to provide a classical file I/O interface, allowing to use
these utilities as library, too. This is consistent and more
comprehensive: the API is realized by fw_env_open, fw_env_write and
fw_env_close.

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2010-05-24  8:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-21 10:52 [U-Boot] [PATCH] Tools: set multiple variable with fw_setenv utility Stefano Babic
2010-05-21 11:38 ` Wolfgang Denk
2010-05-21 15:15   ` Stefano Babic
2010-05-21 16:03     ` Wolfgang Denk
2010-05-21 16:39       ` Stefano Babic
2010-05-21 19:11         ` Wolfgang Denk
2010-05-23 14:29 ` [U-Boot] [PATCH V2] " Stefano Babic
2010-05-24  2:47   ` Peter Tyser
2010-05-24  8:18     ` Stefano Babic [this message]
2010-05-24 10:08   ` [U-Boot] [PATCH V3] " Stefano Babic
2010-06-29 20:43     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BFA3651.2060507@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.