From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50997 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OGeHj-0003EO-PG
	for qemu-devel@nongnu.org; Mon, 24 May 2010 16:30:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OGeHb-0002Mt-Qm
	for qemu-devel@nongnu.org; Mon, 24 May 2010 16:30:03 -0400
Received: from mail-pz0-f181.google.com ([209.85.222.181]:44126)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OGeHb-0002Mk-Hb
	for qemu-devel@nongnu.org; Mon, 24 May 2010 16:29:55 -0400
Received: by pzk11 with SMTP id 11so2144839pzk.28
	for <qemu-devel@nongnu.org>; Mon, 24 May 2010 13:29:54 -0700 (PDT)
Message-ID: <4BFAE1BE.5030800@codemonkey.ws>
Date: Mon, 24 May 2010 15:29:50 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Virtio-net: Replace the hardcode 6 with
	defined ETN_ALEN
References: <1274582950-4418-1-git-send-email-akong@redhat.com>
In-Reply-To: <1274582950-4418-1-git-send-email-akong@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: akong@redhat.com
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, alex.williamson@hp.com

On 05/22/2010 09:49 PM, akong@redhat.com wrote:
> From: Amos Kong<akong@redhat.com>
>
> hw/virtio-net.h:
>      #define ETH_ALEN    6
> ETH_ALEN was defined by commit 7967406801aa897fae83caad3278ac85a342adaa
>
> Signed-off-by: Amos Kong<akong@redhat.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   hw/virtio-net.h |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/virtio-net.h b/hw/virtio-net.h
> index e55119b..235f1a9 100644
> --- a/hw/virtio-net.h
> +++ b/hw/virtio-net.h
> @@ -54,8 +54,8 @@
>
>   struct virtio_net_config
>   {
> -    /* The config defining mac address (6 bytes) */
> -    uint8_t mac[6];
> +    /* The config defining mac address ($ETH_ALEN bytes) */
> +    uint8_t mac[ETH_ALEN];
>       /* See VIRTIO_NET_F_STATUS and VIRTIO_NET_S_* above */
>       uint16_t status;
>   } __attribute__((packed));
>