From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758035Ab0EXVVU (ORCPT ); Mon, 24 May 2010 17:21:20 -0400 Received: from crca.org.au ([74.207.252.120]:52369 "EHLO crca.org.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757804Ab0EXVVT (ORCPT ); Mon, 24 May 2010 17:21:19 -0400 X-Bogosity: Ham, spamicity=0.000000 Message-ID: <4BFAEDC9.1010707@crca.org.au> Date: Tue, 25 May 2010 07:21:13 +1000 From: Nigel Cunningham User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100423 Thunderbird/3.0.4 MIME-Version: 1.0 To: Pavel Machek CC: "Rafael J. Wysocki" , Alan Stern , linux-kernel , Jens Axboe , Andrew Morton , linux-pm , Matt Reimer Subject: Re: [linux-pm] Is it supposed to be ok to call del_gendisk while userspace is frozen? References: <4BF0F3FF.2010603@crca.org.au> <201005172235.37824.rjw@sisk.pl> <4BF1C86B.8000203@crca.org.au> <20100524190206.GL1292@ucw.cz> In-Reply-To: <20100524190206.GL1292@ucw.cz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi. On 25/05/10 05:02, Pavel Machek wrote: > >>>> - We're dealing with the symptom, not the cause. Almost always a bad idea. >>> >>> I very much prefer to have a fix for a symptom than no fix at all, which is the >>> realistic alternative in this case. >>> >>> So, I think we should merge the patch and if someone finds the root cause >>> at one point in future, then we can just use the *right* approach instead of >>> the present one. >>> >>> The problem is real and people in the field are affected by it, so if you don't >>> have a working alternative patch, please just let go. >> >> I'm not denying that the problem is real. What I am concerned about >> is finding a real solution, not just putting a sticky plaster over >> the wound. It seems to me to be much wiser to deal with the issue >> properly now instead of doing extra work later to diagnose what >> might be a harder to reproduce symptom of the same problem. I'd >> happily put the time in now myself, but I simply don't have the time >> this week. >> >> Would it be possible to apply the patch, adding some sort of new tag >> that can be used to say "This needs further attention", perhaps >> including an enduring reference to this conversation. Later, the >> 'real' fix could include another special tag that says "Proper fix >> for the symptom addressed in commit 5e94f810"? > > WARN_ON() whenever patch triggers? I suppose that would do. I was thinking of a more generic git tag that could perhaps be searched for later, but .. okay. Nigel