All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Andre Przywara <andre.przywara@amd.com>,
	qemu-devel@nongnu.org, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH] resent: x86/cpuid: propagate further CPUID leafs when -cpu host
Date: Tue, 25 May 2010 10:27:58 +0300	[thread overview]
Message-ID: <4BFB7BFE.9030707@redhat.com> (raw)
In-Reply-To: <4BFAF941.1010604@codemonkey.ws>

On 05/25/2010 01:10 AM, Anthony Liguori wrote:
> On 05/21/2010 02:50 AM, Andre Przywara wrote:
>> -cpu host currently only propagates the CPU's family/model/stepping,
>> the brand name and the feature bits.
>> Add a whitelist of safe CPUID leafs to let the guest see the actual
>> CPU's cache details and other things.
>>
>> Signed-off-by: Andre Przywara<andre.przywara@amd.com>
>
> The problem I can see is that this greatly increases the chances of 
> problems with live migration since we don't migrate the cpuid state.

-cpu host is already problematic for live migration.

Are you talking about the state maintained by the cpuid instruction?  
Yes, we need to migrate those bits.

>
> What's the benefit of exposing this information to the guest?
>

Some algorithms adjust themselves based on the cache size.  If you have 
several passes over a large data set, it's often better to run each set 
of passes on a subset of the dataset that fits in cache, then stitch the 
subsets together.

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2010-05-25  7:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-21  7:50 [Qemu-devel] [PATCH] resent: x86/cpuid: propagate further CPUID leafs when -cpu host Andre Przywara
2010-05-24 22:10 ` Anthony Liguori
2010-05-25  7:27   ` Avi Kivity [this message]
2010-05-25 13:21   ` Andre Przywara
2010-05-25 13:26     ` Anthony Liguori
2010-05-25 13:47       ` Avi Kivity
2010-05-26 10:52       ` Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BFB7BFE.9030707@redhat.com \
    --to=avi@redhat.com \
    --cc=andre.przywara@amd.com \
    --cc=anthony@codemonkey.ws \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.