From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40455 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGsAZ-0005zA-7A for qemu-devel@nongnu.org; Tue, 25 May 2010 07:19:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OGsAX-0001hW-Mm for qemu-devel@nongnu.org; Tue, 25 May 2010 07:19:35 -0400 Received: from goliath.siemens.de ([192.35.17.28]:19389) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGsAX-0001hM-5R for qemu-devel@nongnu.org; Tue, 25 May 2010 07:19:33 -0400 Message-ID: <4BFBB23E.20800@siemens.com> Date: Tue, 25 May 2010 13:19:26 +0200 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFT][PATCH 09/15] hpet/rtc: Rework RTC IRQ replacement by HPET References: <201005251029.49089.paul@codesourcery.com> <4BFBA539.6010305@siemens.com> <201005251205.02782.paul@codesourcery.com> In-Reply-To: <201005251205.02782.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: blue Swirl , Jan Kiszka , "qemu-devel@nongnu.org" , Juan Quintela Paul Brook wrote: >>> This is wrong. The hpet device should expose this as an IO pin. >> Will look into this. >> >> BTW, I just realized that the GPIO handling is apparently lacking >> support for attaching an output to multiple inputs. Or am I missing >> something? > > Use an explicit mux. > > Incidentally I suspect your handling of the ISA IRQs is broken. You may never > have more than one source connected to a sink. Shared IRQ lines must be done > explicitly. No, the other way around: one source (RTC) multiple sinks (HPET, ACPI). Will probably draft a generic irq/gpio mux. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux