From: Avi Kivity <avi@redhat.com>
To: Mohammed Gamal <m.gamal005@gmail.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] VMX: Properly return error to userspace on vmentry failure
Date: Tue, 25 May 2010 15:10:39 +0300 [thread overview]
Message-ID: <4BFBBE3F.50609@redhat.com> (raw)
In-Reply-To: <AANLkTinEJ__CTW63zC3h9V0My-tED_rpJBRxaiQF_N9f@mail.gmail.com>
On 05/25/2010 03:01 PM, Mohammed Gamal wrote:
>>
>> How does the user distinguish between KVM_EXIT_FAIL_ENTRY due to an exit
>> reason with bit 31 set and vmlauch/vmresume failure (vmx->fail set)? We
>> need separate exit codes (with documentation in api.txt).
>>
> In both cases the vm fails entry, and I don't think the hardware entry
> failure reason codes would overlap between the vmx->fail case and exit
> reasons with bit 31 set, so why should there be such distinction
> between both cases?
>
Only 5 more error codes (28->33) and we have overlap.
If you return the new codes with bit 31 still set then we can use the
existing KVM_EXIT_FAIL_ENTRY.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-05-25 12:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-23 22:01 [PATCH 1/2] VMX: Properly return error to userspace on vmentry failure Mohammed Gamal
2010-05-23 22:01 ` [PATCH 2/2] VMX: Add constant for invalid guest state exit reason Mohammed Gamal
2010-05-25 11:46 ` Avi Kivity
2010-05-25 11:45 ` [PATCH 1/2] VMX: Properly return error to userspace on vmentry failure Avi Kivity
2010-05-25 12:01 ` Mohammed Gamal
2010-05-25 12:10 ` Avi Kivity [this message]
2010-05-25 12:15 ` Mohammed Gamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFBBE3F.50609@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=m.gamal005@gmail.com \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.