From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37778 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGtRa-0004Bi-0O for qemu-devel@nongnu.org; Tue, 25 May 2010 08:41:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OGtQB-0005wR-Ir for qemu-devel@nongnu.org; Tue, 25 May 2010 08:39:48 -0400 Received: from david.siemens.de ([192.35.17.14]:24245) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGtQB-0005w0-79 for qemu-devel@nongnu.org; Tue, 25 May 2010 08:39:47 -0400 Message-ID: <4BFBC50C.9040205@siemens.com> Date: Tue, 25 May 2010 14:39:40 +0200 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFT][PATCH 09/15] hpet/rtc: Rework RTC IRQ replacement by HPET References: <201005251223.14409.paul@codesourcery.com> <4BFBB3F3.20902@siemens.com> <201005251303.43633.paul@codesourcery.com> In-Reply-To: <201005251303.43633.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: blue Swirl , Jan Kiszka , "qemu-devel@nongnu.org" , Juan Quintela Paul Brook wrote: >>> I realise that. However I'd expect things to break if the guest OS >>> devices to share an IRQ line between the HPET and some other device. >> The guest would share IRQ8, not the RTC output. So there would be no >> difference to the current situation. > > The difference is that you've removed the check that prevented overlap between > the PIC and annother device. You should be using isa_reserve_irq/isa_init_irq > before you use an ISA IRQ line. Any uses of isa_bus_irqs (including teh > existing HPET code) are probably broken. ...at least fragile. OK, will address this as well. Thanks, Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux