From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41568 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGuNv-0003hh-Nf for qemu-devel@nongnu.org; Tue, 25 May 2010 09:41:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OGuNu-00025w-Dw for qemu-devel@nongnu.org; Tue, 25 May 2010 09:41:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7768) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGuNu-00025g-6r for qemu-devel@nongnu.org; Tue, 25 May 2010 09:41:30 -0400 Message-ID: <4BFBD375.9030707@redhat.com> Date: Tue, 25 May 2010 16:41:09 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH v2 12/15] monitor: Add basic device state visualization References: <1f557b9feb1965a61e64f7166bcf4918bed8d0ec.1274516288.git.jan.kiszka@web.de> <4BF82895.6000706@redhat.com> <4BFAE004.6090501@codemonkey.ws> <4BFB7B06.2090005@redhat.com> <4BFBCABC.5040707@linux.vnet.ibm.com> <4BFBCE6A.1000201@redhat.com> <4BFBD11E.7030609@codemonkey.ws> In-Reply-To: <4BFBD11E.7030609@codemonkey.ws> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Juan Quintela , Jan Kiszka , qemu-devel@nongnu.org, Luiz Capitulino , Anthony Liguori , Jan Kiszka , Markus Armbruster On 05/25/2010 04:31 PM, Anthony Liguori wrote: > On 05/25/2010 08:19 AM, Avi Kivity wrote: >> On 05/25/2010 04:03 PM, Anthony Liguori wrote: >>>> >>>>> I don't think that qdev device names and paths are something we >>>>> have to worry much about changing over time since they reflect >>>>> logical bus layout. They should remain static provided the >>>>> devices remain static. >>>> >>>> Modulo mistakes. We already saw one (lack of pci domains). To >>>> reduce the possibility of mistakes, we need reviewable documentation. >>> >>> >>> pci domains was only a mistake as a nice-to-have. We can add pci >>> domains in a backwards compatible way. >> >> It adds a new level to the qdev tree. > > The tree is not organized like that today. IOW, the PCI hierarchy is > not reflected in the qdev hierarchy. All PCI devices (regardless of > whether they're a function or a full slot) simply sit below the PCI bus. That's a bug IMO, but regardless, s/qdev tree/pci device component of the qdev path/. -- error compiling committee.c: too many arguments to function