Re: [PATCH] vhost-net: fix reversed logic in mask notifiers

[Gerd Hoffmann <kraxel@redhat.com>]

On 05/25/10 16:00, Michael S. Tsirkin wrote:
> When guest notifier is assigned, we set mask notifier,
> which will assign kvm irqfd.
> When guest notifier is unassigned, mask notifier is unset,
> which should unassign kvm irqfd.
>
> The way to do this is to call mask notifier telling it to mask the vector.
> This, unless vector is already masked which unassigns irqfd already.
>
> The logic in unassign was reversed, which left kvm irqfd assigned.
>
> This patch is qemu-kvm only as irqfd is not upstream.
>
> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>
> Reported-by: Amit Shah<amit.shah@redhat.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

cheers,
   Gerd