From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758834Ab0EYWeu (ORCPT ); Tue, 25 May 2010 18:34:50 -0400 Received: from relay3.sgi.com ([192.48.152.1]:52300 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753903Ab0EYWes (ORCPT ); Tue, 25 May 2010 18:34:48 -0400 Message-ID: <4BFC5080.6030103@sgi.com> Date: Tue, 25 May 2010 15:34:40 -0700 From: Mike Travis User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: "H. Peter Anvin" CC: Yinghai , Ingo Molnar , Thomas Gleixner , x86@kernel.org, Suresh Siddha , Rusty Russell , Jens Axboe , Jack Steiner , LKML , jkosina@novell.com Subject: Re: [Patch 1/1] x86 efi: Fill all reserved memmap entries if add_efi_memmap specified. References: <4BEAEF10.9040809@sgi.com> <4BEAF9B6.2040606@zytor.com> <4BEB0D5F.8070806@oracle.com> <4BEB1781.1080907@sgi.com> <4BEC6C94.2020100@sgi.com> <4BEC73B2.2020909@oracle.com> <4BEC7544.1080506@sgi.com> <4BEC8161.6050206@zytor.com> In-Reply-To: <4BEC8161.6050206@zytor.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org H. Peter Anvin wrote: > On 05/13/2010 02:55 PM, Mike Travis wrote: >> I saw that too, and wondered why e820_saved did not >> have the extra entries. The comment indicates it >> should. >> >> I'm on the system tonight and will investigate this >> further. >> > > e820_saved lacks the extra entries because they aren't being passed in > from the bootloader, as they should, and instead you're using > add_efi_memmap which is, as far as the kernel is concerned, a post-boot > modification. > > That being said, add_efi_memmap does come from the firmware, and as such > it would be legitimate for it to add them to e820_saved. > > -hpa Did this last patch meet expectations? http://marc.info/?l=linux-kernel&m=127474230623061&w=4 Thanks, Mike