From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [tabled patch 2/4] fix the selection of chunk
Date: Tue, 25 May 2010 18:44:11 -0400
Message-ID: <4BFC52BB.7060509@garzik.org>
References: <20100521201945.28d2cce8@redhat.com>
Mime-Version: 1.0
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <hail-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:sender:message-id:date:from
         :user-agent:mime-version:to:cc:subject:references:in-reply-to
         :content-type:content-transfer-encoding;
        bh=WVyip4JIT4pUcJPV0/03aHXuCGmCFjYNeqjuMBfeFP4=;
        b=RUKLL/v0MhaYV/2aJamTIGT64F6t5PN80+jn2QZcRrtHlYrBZ6KIcINDtn9KjhhMWW
         XRN3WFeCiKaaiWMflTp/N5+wgDgupoxnfe4tI5Bk4/3B3zkImvSeFNw5IptZEARxMIdV
         rk2sMMqOLtcUhjxVFS48OZzPMNKYK/3RPFX1Q=
In-Reply-To: <20100521201945.28d2cce8@redhat.com>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="windows-1252"; format="flowed"
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>

On 05/21/2010 10:19 PM, Pete Zaitcev wrote:
> +static int object_node_select(int *nx, struct db_obj_ent *obj)
> +{
> +	int i;
> +	uint32_t nid;
> +	struct storage_node *stnode;
> +
> +	for (i =3D 0; i<  MAXWAY; i++) {
> +		nid =3D GUINT32_FROM_LE(obj->d.a.nidv[*nx]);
> +		if (nid) {
> +			stnode =3D stor_node_by_nid(nid);
> +			if (stnode) {
> +				if (stnode->up)
> +					return stnode;
> +				stor_node_put(stnode);
> +			}
> +		}
> +		*nx =3D (*nx + 1) % MAXWAY;
> +	}
> +	return NULL;
> +}


Did you compile or test this???

object.c: In function =91object_node_select=92:
object.c:1096: warning: return makes integer from pointer without a cas=
t
object.c:1102: warning: return makes integer from pointer without a cas=
t
object.c: In function =91object_get_body=92:
object.c:1220: warning: assignment makes pointer from integer without a=
 cast

The code appears to be wanting to return a pointer.

Dropped patches 2-4, presuming they will be resent after being fixed