From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yang Hongyang <yanghy@cn.fujitsu.com>
Subject: Re: [PATCH] xl: allow nameless domains to be named
Date: Wed, 26 May 2010 08:45:53 +0800
Message-ID: <4BFC6F41.2050306@cn.fujitsu.com>
References: <4BFC369A.7070100@goop.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4BFC369A.7070100@goop.org>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Xen-devel <xen-devel@lists.xensource.com>, Vincent Hanquez <Vincent.Hanquez@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

Hi jeremy,

On 05/26/2010 04:44 AM, Jeremy Fitzhardinge wrote:
> At present, find_domain() will exit(2) if you specify a domain by
> number, but that domain doesn't have a corresponding name.  However,
> nothing seem to critically depend on common_domname being set, and the
> test prevents dom0 or other nameless domains from being named.  So just
> remove the check.

Thank you, for now, remove the check seems to be the solution.

> 
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>

Acked-by: Yang Hongyang <yanghy@cn.fujitsu.com>

> 
> diff -r ba7fdd53f44c tools/libxl/xl_cmdimpl.c
> --- a/tools/libxl/xl_cmdimpl.c	Tue May 25 13:37:20 2010 -0700
> +++ b/tools/libxl/xl_cmdimpl.c	Tue May 25 13:40:53 2010 -0700
> @@ -138,10 +138,6 @@
>          exit(2);
>      }
>      common_domname = was_name ? p : libxl_domid_to_name(&ctx, domid);
> -    if (!common_domname) {
> -        fprintf(stderr, "%s is an invalid domain identifier.\n", p);
> -        exit(2);
> -    }
>  }
>  
>  #define LOG(_f, _a...)   dolog(__FILE__, __LINE__, __func__, _f "\n", ##_a)
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
> 
> 


-- 
Regards
Yang Hongyang