From: Jeff Garzik <jeff@garzik.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: Re: [tabled patch 1/1] fix the selection of chunk
Date: Tue, 25 May 2010 23:46:24 -0400 [thread overview]
Message-ID: <4BFC9990.70309@garzik.org> (raw)
In-Reply-To: <20100525213041.53a1198e@redhat.com>
On 05/25/2010 11:30 PM, Pete Zaitcev wrote:
> If a chunkserver goes down, tabled sometimes throws a phantom "object
> not found". It happens because we keep hitting the same down node and
> exhaust the retries. The existing code calls rand() every time and
> hopes for the best, but this is too likely to end poorly.
>
> The fix is to only randomize once before the retry loop, and then
> cycle through all available nodes deterministically. The same fix
> would apply even if we used a better technique to select an available
> chunkserver than just random.
>
> Also, we refactor the code just a little bit, so that the enormous
> function object_get_body gets somewhat easier to follow.
>
> Signed-off-by: Pete Zaitcev<zaitcev@redhat.com>
applied
prev parent reply other threads:[~2010-05-26 3:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 3:30 [tabled patch 1/1] fix the selection of chunk Pete Zaitcev
2010-05-26 3:46 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFC9990.70309@garzik.org \
--to=jeff@garzik.org \
--cc=hail-devel@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.