All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Vilain <sam@vilain.net>
To: Will Palmer <wmpalmer@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: Apology/Bug report: git-send-email sends everything on Ctrl+C
Date: Wed, 26 May 2010 20:51:58 +1200	[thread overview]
Message-ID: <4BFCE12E.4070009@vilain.net> (raw)
In-Reply-To: <1274861112.2074.2.camel@wpalmer.simply-domain>

Will Palmer wrote:
>> I think I must have actually hit Ctrl-Z, not Ctrl-C.  So, it's all my
>> fault and I apologize profusely.
>>     
> I'd consider anything that can make "accidentally sending 100+ patches"
> possible to be a bug. How does "it was Ctrl-Z, not Ctrl-C" make a
> difference here?

This was what I did;

on git.git next or so; I was thinking "hmm, how does git send-email
format the cover letter for editing by the user?  I know, I'll just check":

 $ git send-email --compose HEAD~5..

(tab around a bit, I think I hit ctrl+z because my history has "jobs" in
it just after that command)

(poke around in the git-send-email source a bit)

(inspect the file it produced, oh look, HEAD~5.. matches an awful lot of
commits)

(close edit window without changes)

(notice hundreds of e-mail headers being spewed out)

Ctrl+C.  nothing (it's in the background)

Ctrl+C again.  argh!  What MTA am I running?

 $ sudo /etc/init.d/postfix stop
 $ sudo /etc/init.d/exim4 stop
 $ cat .git/config

Oh no, it's going to a mail server I don't have root on.  It was fully
configured so it didn't need to ask any questions, just fire away.  Why
did I test that on my git.git checkout?

Quick, find a friendly sysadmin and mailq | grep sam.vilain | cut -d" "
-f1 | sudo xargs -n1 postsuper -d

Hard to know what could have possibly stopped this from happening.  PEBKAC.

Sam

  reply	other threads:[~2010-05-26  8:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-26  6:04 Apology/Bug report: git-send-email sends everything on Ctrl+C Sam Vilain
2010-05-26  6:50 ` Sam Vilain
2010-05-26  8:05   ` Will Palmer
2010-05-26  8:51     ` Sam Vilain [this message]
2010-05-26  9:07       ` Sverre Rabbelier
2010-05-26  9:16         ` Michael J Gruber
2010-05-26  9:27           ` Sam Vilain
2010-05-26  8:40   ` Michael J Gruber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BFCE12E.4070009@vilain.net \
    --to=sam@vilain.net \
    --cc=git@vger.kernel.org \
    --cc=wmpalmer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.