All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Frank Mehnert <Frank.Mehnert@Sun.COM>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: hw/serial.c: Xmit fifo never used
Date: Wed, 26 May 2010 13:16:12 +0200	[thread overview]
Message-ID: <4BFD02FC.6020401@siemens.com> (raw)
In-Reply-To: <201005261306.07673.frank.mehnert@sun.com>

Frank Mehnert wrote:
> On Wednesday 26 May 2010, Jan Kiszka wrote:
>> Frank Mehnert wrote:
>>> I assume the correct condition would be '>= 0', that is
>>>
>>>         ...
>>>         if ((s->tsr_retry >= 0) && (s->tsr_retry <= MAX_XMIT_RETRY)) {
>>>             s->tsr_retry++;
>>>         ...
>> Makes sense, patch welcome.
> 
> Attached.

Signed-off, subject, and description please. And I would keep Stefano as
the original author of this feature in CC. A cross-check by him might be
good as we enable a code path that was apparently dead so far.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

  reply	other threads:[~2010-05-26 11:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-26 10:07 [Qemu-devel] hw/serial.c: Xmit fifo never used Frank Mehnert
2010-05-26 10:32 ` [Qemu-devel] " Jan Kiszka
2010-05-26 11:06   ` Frank Mehnert
2010-05-26 11:16     ` Jan Kiszka [this message]
2010-05-26 11:42       ` Stefano Stabellini
2010-05-26 20:06         ` Frank Mehnert
2010-05-27  8:21           ` Jan Kiszka
2010-05-28 14:31 ` [Qemu-devel] " Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BFD02FC.6020401@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=Frank.Mehnert@Sun.COM \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.