From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] hotplug/shpchp_hpc: add parenthesis in SLOT_REG_RSVDZ_MASK
Date: Wed, 26 May 2010 11:29:59 +0000 [thread overview]
Message-ID: <4BFD0637.8070300@jp.fujitsu.com> (raw)
In-Reply-To: <20100526104639.GA16631@bicker>
Good catch.
Reviewed-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
(2010/05/26 19:46), Dan Carpenter wrote:
> The SLOT_REG_RSVDZ_MASK macro is normally used like this:
> slot_reg&= ~SLOT_REG_RSVDZ_MASK;
> The ~ operator has higher precedence than the | operator from inside the
> macro, so it needs parenthesis.
>
> Signed-off-by: Dan Carpenter<error27@gmail.com>
>
> diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c
> index 5f5e8d2..d3985e7 100644
> --- a/drivers/pci/hotplug/shpchp_hpc.c
> +++ b/drivers/pci/hotplug/shpchp_hpc.c
> @@ -113,7 +113,7 @@
> #define CON_PFAULT_INTR_MASK (1<< 28)
> #define MRL_CHANGE_SERR_MASK (1<< 29)
> #define CON_PFAULT_SERR_MASK (1<< 30)
> -#define SLOT_REG_RSVDZ_MASK (1<< 15) | (7<< 21)
> +#define SLOT_REG_RSVDZ_MASK ((1<< 15) | (7<< 21))
>
> /*
> * SHPC Command Code definitnions
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
prev parent reply other threads:[~2010-05-26 11:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 10:46 [patch] hotplug/shpchp_hpc: add parenthesis in SLOT_REG_RSVDZ_MASK Dan Carpenter
2010-05-26 11:29 ` Kenji Kaneshige [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFD0637.8070300@jp.fujitsu.com \
--to=kaneshige.kenji@jp.fujitsu.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.