From: "Justin P. Mattock" <justinmattock@gmail.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: linville@tuxdriver.com, arnd@arndnet.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH][RESEND] ath9k: Fix ath_print in xmit for hardware reset.
Date: Wed, 26 May 2010 11:07:39 -0700 [thread overview]
Message-ID: <4BFD636B.3070607@gmail.com> (raw)
In-Reply-To: <AANLkTilII7C41BTshkXyCmAU81LQ3fJF0ogq_BLVv6w-@mail.gmail.com>
On 05/26/2010 11:02 AM, Luis R. Rodriguez wrote:
> On Wed, May 26, 2010 at 11:00 AM, Justin P. Mattock
> <justinmattock@gmail.com> wrote:
>
>> ath_print in xmit.c should say "Reseting hardware"
>> instead of Resetting HAL!(since HAL is being fazed out).
>> dmesg shows:
>> [ 8660.899624] ath: Failed to stop TX DMA in 100 msec after killing last frame
>> [ 8660.899676] ath: Unable to stop TxDMA. Reset HAL!
>>
>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>
>>
> For next time, no need for extra spaces between the SOB and the ---.
> And instead of RESEND do [PATCH v2]. Please read:
>
> http://wireless.kernel.org/en/developers/Documentation/git-guide
>
>
o.k.!!
>> ---
>> drivers/net/wireless/ath/ath9k/xmit.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
>> index 3db1917..09cb13c 100644
>> --- a/drivers/net/wireless/ath/ath9k/xmit.c
>> +++ b/drivers/net/wireless/ath/ath9k/xmit.c
>> @@ -1198,7 +1198,7 @@ void ath_drain_all_txq(struct ath_softc *sc, bool retry_tx)
>> int r;
>>
>> ath_print(common, ATH_DBG_FATAL,
>> - "Unable to stop TxDMA. Reset HAL!\n");
>> + "Failed to stop TX DMA. Resetting hardware!\n");
>>
>> spin_lock_bh(&sc->sc_resetlock);
>> r = ath9k_hw_reset(ah, sc->sc_ah->curchan, false);
>>
> Thanks, this is good.
>
> Luis
>
>
what about all the signed-off's? should I
resend with all of those, or no?
Justin P. Mattock
next prev parent reply other threads:[~2010-05-26 18:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 18:00 [PATCH][RESEND] ath9k: Fix ath_print in xmit for hardware reset Justin P. Mattock
2010-05-26 18:02 ` Luis R. Rodriguez
2010-05-26 18:07 ` Justin P. Mattock [this message]
2010-05-26 18:09 ` Luis R. Rodriguez
2010-05-26 18:12 ` Justin P. Mattock
2010-05-26 18:14 ` Luis R. Rodriguez
2010-05-26 18:34 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFD636B.3070607@gmail.com \
--to=justinmattock@gmail.com \
--cc=arnd@arndnet.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.