From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: [PATCH v2] KVM: Fix order passed to iommu_unmap Date: Wed, 26 May 2010 21:36:33 +0200 Message-ID: <4BFD7841.9060302@web.de> References: <4BFD7686.2030109@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: kvm , Joerg Roedel , Zachary Amsden To: Avi Kivity , Marcelo Tosatti Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:50424 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755541Ab0EZTgf (ORCPT ); Wed, 26 May 2010 15:36:35 -0400 In-Reply-To: <4BFD7686.2030109@web.de> Sender: kvm-owner@vger.kernel.org List-ID: From: Jan Kiszka This is obviously a left-over from the the old interface taking the size. Apparently a mostly harmless issue with the current iommu_unmap implementation. Signed-off-by: Jan Kiszka --- I think this one is even closer to the right order. :) virt/kvm/iommu.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/virt/kvm/iommu.c b/virt/kvm/iommu.c index 5adc578..673c88a 100644 --- a/virt/kvm/iommu.c +++ b/virt/kvm/iommu.c @@ -273,7 +273,7 @@ static void kvm_iommu_put_pages(struct kvm *kvm, pfn = phys >> PAGE_SHIFT; /* Unmap address from IO address space */ - order = iommu_unmap(domain, gfn_to_gpa(gfn), PAGE_SIZE); + order = iommu_unmap(domain, gfn_to_gpa(gfn), 0); unmap_pages = 1ULL << order; /* Unpin all pages we just unmapped to not leak any memory */