All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dm9000x.c: fix compile problems
Date: Wed, 26 May 2010 14:44:03 -0700	[thread overview]
Message-ID: <4BFD9623.3070708@gmail.com> (raw)
In-Reply-To: <1274905266-25143-1-git-send-email-wd@denx.de>

Hi Wolfgang,

On 5/26/2010 1:21 PM, Wolfgang Denk wrote:
> Use readX() / writeX() accessors instead of inX() / outX().
>
> Suggested-by: Mike Frysinger<vapier@gentoo.org>
> Signed-off-by: Wolfgang Denk<wd@denx.de>
> ---
>   drivers/net/dm9000x.c |   12 ++++++------
>   1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c
> index f121286..137e41f 100644
> --- a/drivers/net/dm9000x.c
> +++ b/drivers/net/dm9000x.c
> @@ -117,12 +117,12 @@ static void DM9000_iow(int reg, u8 value);
>
>   /* DM9000 network board routine ---------------------------- */
>
> -#define DM9000_outb(d,r) outb(d, r)
> -#define DM9000_outw(d,r) outw(d, r)
> -#define DM9000_outl(d,r) outl(d, r)
> -#define DM9000_inb(r) inb(r)
> -#define DM9000_inw(r) inw(r)
> -#define DM9000_inl(r) inl(r)
> +#define DM9000_outb(d,r) writeb(d, r)
> +#define DM9000_outw(d,r) writew(d, r)
> +#define DM9000_outl(d,r) writel(d, r)
> +#define DM9000_inb(r) readb(r)
> +#define DM9000_inw(r) readw(r)
> +#define DM9000_inl(r) readl(r)
>
>   #ifdef CONFIG_DM9000_DEBUG
>   static void
>    
Looks good to me.  Please apply directly.

regards,
Ben

  parent reply	other threads:[~2010-05-26 21:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-26 20:21 [U-Boot] [PATCH] dm9000x.c: fix compile problems Wolfgang Denk
2010-05-26 21:39 ` Andreas Bießmann
2010-05-26 21:44 ` Ben Warren [this message]
2010-05-26 22:19   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BFD9623.3070708@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.