From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] vhost_net.c: v2 Fix build failure introduced by 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2
Date: Thu, 27 May 2010 12:59:04 +0200 [thread overview]
Message-ID: <4BFE5078.1030805@redhat.com> (raw)
In-Reply-To: <20100527105355.GA7313@redhat.com>
On 05/27/10 12:53, Michael S. Tsirkin wrote:
> On Thu, May 27, 2010 at 12:55:49PM +0200, Jes Sorensen wrote:
>> On 05/27/10 12:44, Michael S. Tsirkin wrote:
>>> I think this part of 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2
>>> should just be reverted. We have unsigned long, it should be printed
>>> woith %ll. Casting to uint64_t just so we can print with PRIu64 seems silly.
>>
>> That is an option too. Problem is just that unsigned long is 32 bit on
>> 32 bit systems and Windows (even for 64 bit) so if we need more flags we
>> need to be careful with it.
>>
>> Cheers,
>> Jes
>
> I don't understand, sorry.
> This field is unsigned long long, not unsigned long.
> %ll will print unsigned long long
> for any standard printf, whatever its length.
Ah ok, if the field is long long, then your patch should be just fine. I
hadn't checked that was the case.
Cheers,
Jes
next prev parent reply other threads:[~2010-05-27 10:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 10:22 [Qemu-devel] [PATCH] vhost_net.c: v2 Fix build failure introduced by 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2 Jes.Sorensen
2010-05-27 10:44 ` [Qemu-devel] " Michael S. Tsirkin
2010-05-27 10:55 ` Jes Sorensen
2010-05-27 10:53 ` Michael S. Tsirkin
2010-05-27 10:59 ` Jes Sorensen [this message]
2010-05-27 10:54 ` Michael S. Tsirkin
2010-05-27 11:04 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFE5078.1030805@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.