From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] vhost-net: fix reversed logic in mask notifiers Date: Thu, 27 May 2010 16:54:27 +0300 Message-ID: <4BFE7993.9030901@redhat.com> References: <20100525140043.GA19688@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, amit.shah@redhat.com, quintela@redhat.com, kraxel@redhat.com To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:49414 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751100Ab0E0Ny2 (ORCPT ); Thu, 27 May 2010 09:54:28 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4RDsSRp005292 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 27 May 2010 09:54:28 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o4RDsRcH032220 for ; Thu, 27 May 2010 09:54:28 -0400 In-Reply-To: <20100525140043.GA19688@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/25/2010 05:00 PM, Michael S. Tsirkin wrote: > When guest notifier is assigned, we set mask notifier, > which will assign kvm irqfd. > When guest notifier is unassigned, mask notifier is unset, > which should unassign kvm irqfd. > > The way to do this is to call mask notifier telling it to mask the vector. > This, unless vector is already masked which unassigns irqfd already. > > The logic in unassign was reversed, which left kvm irqfd assigned. > > This patch is qemu-kvm only as irqfd is not upstream. > Applied, thanks. -- error compiling committee.c: too many arguments to function