From mboxrd@z Thu Jan  1 00:00:00 1970
From: Prarit Bhargava <prarit@redhat.com>
Subject: Re: [PATCH]: i915: Fix missing linux/types.h warning in header
Date: Thu, 27 May 2010 11:39:17 -0400
Message-ID: <4BFE9225.1060408@redhat.com>
References: <20100527151952.22661.61352.sendpatchset@prarit.bos.redhat.com>
	<4BFE8FCA.5020700@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
	by gabe.freedesktop.org (Postfix) with ESMTP id A268C9EC57
	for <dri-devel@lists.freedesktop.org>;
	Thu, 27 May 2010 08:43:32 -0700 (PDT)
In-Reply-To: <4BFE8FCA.5020700@oracle.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Alan Coopersmith <alan.coopersmith@oracle.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

>
> Prarit Bhargava wrote:
>    
>> Fixes warning:
>>
>> /usr/include/drm/i915_drm.h:119: found __[us]{8,16,32,64} type without #include<linux/types.h>
>>
>> Signed-off-by: Prarit Bhargava<prarit@redhat.com>
>>
>> diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
>> index b64a8d7..5cf7f5b 100644
>> --- a/include/drm/i915_drm.h
>> +++ b/include/drm/i915_drm.h
>> @@ -27,6 +27,7 @@
>>   #ifndef _I915_DRM_H_
>>   #define _I915_DRM_H_
>>
>> +#include<linux/types.h>
>>   #include "drm.h"
>>      
> drm.h includes it, safely tucked inside #ifdef __linux__ so it won't
> break BSD&  OpenSolaris DRI builds - isn't that good enough?
>    

Hmm ... it doesn't appear to be :/  From a week-old compile of linux-next

/home/linux-next/usr/include/drm/drm_mode.h:84: found __[us]{8,16,32,64} 
type without #include <linux/types.h>
/home/linux-next/usr/include/drm/i915_drm.h:119: found 
__[us]{8,16,32,64} type without #include <linux/types.h>
/home/linux-next/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} 
type without #include <linux/types.h>
/home/linux-next/usr/include/drm/radeon_drm.h:758: found 
__[us]{8,16,32,64} type without #include <linux/types.h>
/home/linux-next/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} 
type without #include <linux/types.h>

It could certainly be that the error check is busted ...

P.
>