From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57356 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OHfFl-0003bZ-4O
	for qemu-devel@nongnu.org; Thu, 27 May 2010 11:44:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1OHfFg-00063E-6V
	for qemu-devel@nongnu.org; Thu, 27 May 2010 11:44:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57964)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1OHfFf-000633-RV
	for qemu-devel@nongnu.org; Thu, 27 May 2010 11:44:08 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4RFi5I8028358
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 27 May 2010 11:44:06 -0400
Message-ID: <4BFE9343.1070500@redhat.com>
Date: Thu, 27 May 2010 17:44:03 +0200
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
References: <1274968015-23599-1-git-send-email-Jes.Sorensen@redhat.com>
	<4BFE8148.90806@redhat.com> <4BFE91DD.5090409@redhat.com>
In-Reply-To: <4BFE91DD.5090409@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] block.h: Make BDRV_SECTOR_SIZE 64 bit safe
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org

On 05/27/10 17:38, Paolo Bonzini wrote:
> On 05/27/2010 04:27 PM, Kevin Wolf wrote:
>> Am 27.05.2010 15:46, schrieb Jes.Sorensen@redhat.com:
>>> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>>>
>>> C defaults to int, so make definition of BDRV_SECTOR_SIZE 64 bit
>>> safe as it and BDRV_SECTOR_MASK may be used against 64 bit addresses.
>>>
>>> Signed-off-by: Jes Sorensen<Jes.Sorensen@redhat.com>
>>
>> Thanks, applied to the block branch.
> 
> Candidate for stable too?

It should be safe to apply, but I didn't find any current users where
the mask was applied in a way where it was causing problems. Not sure if
you want the noise, or apply it as better safe than sorry?

Cheers,
Jes