Re: [PATCH v5 07/12] MIPS/Perf-events: add raw event support for mipsxx 24K/34K/74K/1004K

[David Daney <david.s.daney@gmail.com>]

On 05/27/2010 06:03 AM, Deng-Cheng Zhu wrote:
> Raw event is an important part of Perf-events. It helps the user collect
> performance data for events that are not listed as the generic hardware
> events and cache events but ARE supported by the CPU's PMU.
>
> This patch adds this feature for mipsxx 24K/34K/74K/1004K. For how to use
> it, please refer to processor core software user's manual and the
> comments for mipsxx_pmu_map_raw_event() for more details.
>
> Please note that this is a "precise" implementation, which means the
> kernel will check whether the requested raw events are supported by this
> CPU and which hardware counters can be assigned for them.
>
> Signed-off-by: Deng-Cheng Zhu<dengcheng.zhu@gmail.com>
> ---
>   arch/mips/kernel/perf_event.c        |    4 +
>   arch/mips/kernel/perf_event_mipsxx.c |  152 +++++++++++++++++++++++++++++++++-
>   2 files changed, 155 insertions(+), 1 deletions(-)
>

Should this just be folded into the other patches?

I would also reiterate that perhaps the generic support functions be 
separated from the processor specific event definitions.

David Daney