diff for duplicates of <4BFF709D.5040005@bfs.de> diff --git a/a/1.txt b/N1/1.txt index 7aade0f..f5f2508 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,12 +1,12 @@ Richard Hartmann schrieb: -> =It seems LKML & netdev were dropped from the To list, re-adding= +> ==It seems LKML & netdev were dropped from the To list, re-adding== > > Hi Walter, > > ->> if (ppp->rrsched % ppp->n_channels = i) +>> if (ppp->rrsched % ppp->n_channels == i) >> >> since both do not change in that while() loop you can calculate in advance >> perhaps ppp->rrsched %= ppp->n_channels before the while ? @@ -36,7 +36,7 @@ that would requiere the changes but explain what it actualy is > ->> btw: you are doing after loop() if(pch->chan = NULL) continue; +>> btw: you are doing after loop() if(pch->chan == NULL) continue; >> that means the else in the if below if (pch->chan) should never be reached. >> Or is it likely that some channel will be dropped (?) ? > @@ -44,7 +44,7 @@ that would requiere the changes but explain what it actualy is > please add a comment about that. i can garantee you someone will spot it -and remove either the pch->chan = NULL or the else. +and remove either the pch->chan == NULL or the else. diff --git a/a/content_digest b/N1/content_digest index 5ae0993..53ccacc 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -6,7 +6,7 @@ "ref\0AANLkTikeld4fbr9r1Sq0jhfkWxf0ZlwOsufUIRvb1rFH@mail.gmail.com\0" "From\0walter harms <wharms@bfs.de>\0" "Subject\0Re: [Patch] fix packet loss and massive ping spikes with PPP \tmulti-link\0" - "Date\0Fri, 28 May 2010 07:28:29 +0000\0" + "Date\0Fri, 28 May 2010 09:28:29 +0200\0" "To\0Richard Hartmann <richih.mailinglist@gmail.com>\0" "Cc\0linux-kernel@vger.kernel.org" netdev@vger.kernel.org @@ -17,12 +17,12 @@ "\n" "\n" "Richard Hartmann schrieb:\n" - "> =It seems LKML & netdev were dropped from the To list, re-adding=\n" + "> ==It seems LKML & netdev were dropped from the To list, re-adding==\n" "> \n" "> Hi Walter,\n" "> \n" "> \n" - ">> if (ppp->rrsched % ppp->n_channels = i)\n" + ">> if (ppp->rrsched % ppp->n_channels == i)\n" ">>\n" ">> since both do not change in that while() loop you can calculate in advance\n" ">> perhaps ppp->rrsched %= ppp->n_channels before the while ?\n" @@ -52,7 +52,7 @@ "\n" "\n" "> \n" - ">> btw: you are doing after loop() if(pch->chan = NULL) continue;\n" + ">> btw: you are doing after loop() if(pch->chan == NULL) continue;\n" ">> that means the else in the if below if (pch->chan) should never be reached.\n" ">> Or is it likely that some channel will be dropped (?) ?\n" "> \n" @@ -60,7 +60,7 @@ "> \n" "\n" "please add a comment about that. i can garantee you someone will spot it\n" - "and remove either the pch->chan = NULL or the else.\n" + "and remove either the pch->chan == NULL or the else.\n" "\n" "\n" "\n" @@ -82,4 +82,4 @@ "> Richard\n" > -b1b287ed1ef47cc40cc7397f240eeb5749da28b7d0e1dcc41424d84bdfcc38bc +a5864b9fadc0da5d7ab853747431c015f3f716993fb1c58af3e224830f9999cc
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.