From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1OHyS4-0004o0-EP for mharc-grub-devel@gnu.org; Fri, 28 May 2010 08:14:12 -0400 Received: from [140.186.70.92] (port=43562 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OHyS1-0004jo-1L for grub-devel@gnu.org; Fri, 28 May 2010 08:14:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OHyS0-00044m-3d for grub-devel@gnu.org; Fri, 28 May 2010 08:14:08 -0400 Received: from mail-bw0-f41.google.com ([209.85.214.41]:52421) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHyRz-00044a-Uk for grub-devel@gnu.org; Fri, 28 May 2010 08:14:08 -0400 Received: by bwz12 with SMTP id 12so82030bwz.0 for ; Fri, 28 May 2010 05:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=UHcIxyAyEiNcznVlHb3izgzOoQj8Jk9FLCV8qKPwapQ=; b=iRmfVvT10Vnoj29AoIDV8JfZGlJAG2WTWlkSlKK6FSJCX+6RfH22tJdAu//0IwOUNp 2whHN9QCwB/B6a1A3IwTerjSsCfxkPaf8/SP3dEsH8kgem9uiES6zscBvsGy+7DWHqGl ngPpfrvGCfIKOq5r4CkihFaQ85bis80xhwDis= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=ewdegknZQ5I7QmWvnALPzzol0OyauZTKJF+SxhOftJ4k5cbuRb1COXxyejjptI+97v J4L3uYpsOHzq0Bg9GS1iEx6V5KmjF6PlgcAaUjfRi8UQ8/ca66dMIDjcsSvnfdEnqYAm Hwgb7cJciT+aX+fc2zlIG95SB4+Vcvqca8BKE= Received: by 10.204.83.132 with SMTP id f4mr100141bkl.73.1275048845684; Fri, 28 May 2010 05:14:05 -0700 (PDT) Received: from debian.bg45.phnet (gprs47.swisscom-mobile.ch [193.247.250.47]) by mx.google.com with ESMTPS id l1sm10191605bkl.20.2010.05.28.05.14.03 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 28 May 2010 05:14:04 -0700 (PDT) Message-ID: <4BFFB380.3020801@gmail.com> Date: Fri, 28 May 2010 14:13:52 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: <4BFA94A8.6030407@gmail.com> In-Reply-To: X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig7258A30C901FC9FB9FDB07DB" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [Patch] File name transformations & grub-mkconfig --root-directory X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 May 2010 12:14:10 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7258A30C901FC9FB9FDB07DB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable BVK Chaitanya wrote: > A general comment, not specific your patch: IMO we should make these > scripts in grub.d, standalone, i.e., instead of assuming some > environment variables (like GRUB_DEVICE), they should accept values > through command line arguments, like --root-device=3D/dev/sda or > similar. > > Thus, final result should be something like, with appropriate cmdline > parameters, 10_linux script should print menu entries for all > identified Linux distros, etc. > > =20 Why? Every change must have a clear goal. Here I don't see the usecase. End-user should never run those scripts directly. And for debugging it's more interesting to have this script run in the same environment as it's used. Changing for the sake of changing is NOT good. > > > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig7258A30C901FC9FB9FDB07DB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAkv/s4YACgkQNak7dOguQgl3NQD/ZDjk4o3MK0TZscTsfBgci1Uh k3+0/goX2IUQZs34zwMBALpWiwskb/PnHQlbag++fLnoned33+Roi+J7Q3qoMArG =2tXO -----END PGP SIGNATURE----- --------------enig7258A30C901FC9FB9FDB07DB--