From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] ALSA/davinci: Use the resource_size , __devinit and __devexit. Date: Fri, 28 May 2010 17:33:15 +0400 Message-ID: <4BFFC61B.7050402@mvista.com> References: <4BFF541F.2080209@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4BFF541F.2080209-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: davinci-linux-open-source-bounces-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org Errors-To: davinci-linux-open-source-bounces-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org To: Wan ZongShun Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org, Mark Brown , alsa-devel List-Id: alsa-devel@alsa-project.org Hello. Wan ZongShun wrote: > Dear all, > Use the resource_size function instead of manually calculating the > resource size. This reduces the chance of introducing off-by-one > errors. > In addition, to use __devinit and __devexit is good too. "Good" isn't a good justification I think. Also, this just asks to be put into two patches instead of one as the patch does two completely different things. > Signed-off-by:Wan ZongShun WBR, Sergei