Re: [Qemu-devel] [PATCH 0/4] Cleanups for block code

[Kevin Wolf <kwolf@redhat.com>]

Am 27.05.2010 16:20, schrieb Jes.Sorensen@redhat.com:
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
> 
> Hi,
> 
> Reading through some of the blk code, I noticed a lot of cases where
> we mix and match between hard-coded values for the block size of 512
> and using BDRV_SECTOR_SIZE. Trying to clean it up a bit and change the
> 512 constants to BDRV_SECTOR_SIZE as it is more explaning when reading
> the code.
> 
> In addition it fixes up a case in bdrv_open where we did the division,
> just to multiply back to the original value for no real reason.
> 
> Cheers,
> Jes
> 
> 
> Jes Sorensen (4):
>   Cleanup: bdrv_open() no need to shift total_size just to shift back.
>   Cleanup: Be consistent and use BDRV_SECTOR_SIZE instead of 512
>   Cleanup: raw-posix.c: Be more consistent using BDRV_SECTOR_SIZE
>     instead of 512
>   Cleanup: virtio-blk.c: Be more consistent using BDRV_SECTOR_SIZE
>     instead

Thanks, applied all to the block branch.

Kevin