From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: Null-pointer access in netback_uevent Date: Fri, 28 May 2010 10:28:16 -0700 Message-ID: <4BFFFD30.6000807@goop.org> References: <20100527165558.GA11358@wavehammer.waldi.eu.org> <20100528090325.GA13575@wavehammer.waldi.eu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100528090325.GA13575@wavehammer.waldi.eu.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Bastian Blank , James Harper , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 05/28/2010 02:03 AM, Bastian Blank wrote: > On Fri, May 28, 2010 at 10:47:48AM +1000, James Harper wrote: > >>>> I noticed this just after I posted (subject "oops starting domain on 4.0.0 >>>> + 2.6.32.13-gf6fe658"). I'm getting the same error. >>>> >>> Actually my error is occurring because 'be' is NULL in netback_uevent (eg >>> dev_get_drvdata returns NULL) >>> >> Looking into this further, I suspect that the trigger here is a newer version of udev or something in that area. netback_uevent is getting called before the call to netback_probe containing the call to dev_set_drvdata. >> > There are two problems there. And yes, the uevent routine can be called > at any time. > So would it be correct for it to just return if either of those are NULL? Will it get called again later once the device info is available? J