Re: [PATCH] V4L/DVB: New NXP tda18218 tuner

[Antti Palosaari <crope@iki.fi>]

Terve,

On 05/20/2010 12:52 PM, Nikola Pajkovsky wrote:
> Signed-off-by: Nikola Pajkovsky<npajkovs@redhat.com>
> ---
>   drivers/media/common/tuners/Kconfig         |    7 +
>   drivers/media/common/tuners/Makefile        |    1 +
>   drivers/media/common/tuners/tda18218.c      |  432 +++++++++++++++++++++++++++
>   drivers/media/common/tuners/tda18218.h      |   44 +++
>   drivers/media/common/tuners/tda18218_priv.h |   36 +++
>   drivers/media/dvb/dvb-usb/af9015.c          |   13 +-
>   drivers/media/dvb/frontends/af9013.c        |   15 +
>   drivers/media/dvb/frontends/af9013_priv.h   |    5 +-
>   8 files changed, 548 insertions(+), 5 deletions(-)
>   create mode 100644 drivers/media/common/tuners/tda18218.c
>   create mode 100644 drivers/media/common/tuners/tda18218.h
>   create mode 100644 drivers/media/common/tuners/tda18218_priv.h

tda18218_write_reg() could use tda18218_write_regs()

tda18218_set_params() correct frequency limits. No need to check both 
upper and lower limit.

printk(KERN_INFO "We've got a lock!");
it does not sounds good idea to print INFO when lock

while(i < 10) {
use for loop insted. Two rows less code.

tda18218_init()
why return -EREMOTEIO; ?

tda18218_attach()
printk(KERN_WARNING "Device is not a TDA18218!\n");
we should fail without noise since many times tuner attach is used for 
probe correct tuner

A lot of error checkings are missing when reg write / read

checkpatch returns a lot of warnings and for errors too almost every 
file changed

Is that checked TDA18218 uses same demod settings as TDA18271?

And the biggest problem is that driver author Lauris haven't replied any 
mails...

regards
Antti


-- 
http://palosaari.fi/