From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: Null-pointer access in netback_uevent
Date: Fri, 28 May 2010 16:30:48 -0700
Message-ID: <4C005228.5060107@goop.org>
References: <20100527165558.GA11358@wavehammer.waldi.eu.org>
	<AEC6C66638C05B468B556EA548C1A77D01996BD8@trantor>
	<AEC6C66638C05B468B556EA548C1A77D01996BDB@trantor>
	<AEC6C66638C05B468B556EA548C1A77D01996BE0@trantor>
	<20100528090325.GA13575@wavehammer.waldi.eu.org>
	<4BFFFD30.6000807@goop.org>
	<AEC6C66638C05B468B556EA548C1A77D01996C1F@trantor>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <AEC6C66638C05B468B556EA548C1A77D01996C1F@trantor>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: James Harper <james.harper@bendigoit.com.au>
Cc: Bastian Blank <waldi@debian.org>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 05/28/2010 03:42 PM, James Harper wrote:
>>>> Looking into this further, I suspect that the trigger here is a newer
>>>> version of udev or something in that area. netback_uevent is getting called
>>>> before the call to netback_probe containing the call to dev_set_drvdata.
>>>>
>>>>         
>>> There are two problems there. And yes, the uevent routine can be called
>>> at any time.
>>>
>>>       
>> So would it be correct for it to just return if either of those are
>> NULL?
>>     
> Not sure. It works though.
>   

Can you send me a properly signed-off patch?

Thanks,
    J