Re: [PATCH] libata-sff: trivial corrections to Kconfig help text

[Tejun Heo <tj@kernel.org>]

On 05/29/2010 12:47 PM, Stefan Richter wrote:
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Acked-by: Tejun Heo <tj@kernel.org>

> ---
>  drivers/ata/Kconfig |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 73f8833..aa85a98 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -168,10 +168,10 @@ config ATA_BMDMA
>  	default y
>  	help
>  	  This option adds support for SFF ATA controllers with BMDMA
> -	  capability.  BMDMA stands for bus-master DMA and the
> -	  de-facto DMA interface for SFF controllers.
> +	  capability.  BMDMA stands for bus-master DMA and is the
> +	  de facto DMA interface for SFF controllers.
>  
> -	  If unuser, say Y.
> +	  If unsure, say Y.
>  
>  if ATA_BMDMA
>  
> 
> By the way, is there something that could be said in a few words in the
> help text when to enable that option and when not?

Hmmmm... maybe we can emphasize the 'if unsure, say Y' part?

> Or could that option even be hidden and 'select'ed by bus master DMA
> capable ATA SFF drivers?

I wanted to make the distinction clear so made the option explicit.
Opinions on whether that is actually a good idea would differ but at
the same time, I don't think this would cause any problem, would it?

Thanks.

-- 
tejun